Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New BLOM/iHAMOCC release-1.7 branch for NorESM2.5? #438

Closed
TomasTorsvik opened this issue Nov 27, 2024 · 9 comments
Closed

New BLOM/iHAMOCC release-1.7 branch for NorESM2.5? #438

TomasTorsvik opened this issue Nov 27, 2024 · 9 comments
Assignees
Labels
code release Issues related to upcoming code release or tagging

Comments

@TomasTorsvik
Copy link
Contributor

TomasTorsvik commented Nov 27, 2024

Jörg, Jöran and myself were discussing if it would be useful to create a new release-1.7 branch from master, targeting the NorESM2.3 release. We already created release-1.6 for this purpose before summer, and there have been more changes in the master branch since then, but we still have MCT as an option.

Some suggestions for making a branch:

  • Create a branch today, including all changes since departing from v1.6.1
  • Create a branch before disposing of the "cgs" option
  • Create a branch before disposing of MCT

Today a noresm2_3_alpha01 tag was created, and we should make sure that any changes from BLOM/iHAMOCC does not interfere with testing and tuning towards a NorESM2.3 release. Hence we should probably avoid introducing code changes that change default settings to a large extent.

Linked issue: #340

@gold2718
Copy link

Is the release-1.6 branch not appropriate for this? Is it for NorESM2.1?

@TomasTorsvik
Copy link
Contributor Author

Is the release-1.6 branch not appropriate for this? Is it for NorESM2.1?

At the moment we have

release-1.4  ->  NorESM2.0.X
release-1.5  ->  NorESM2.1.X
release-1.6  ->  NorESM2.3.X
master  ->  NorESM2.5.X

Until now we have tried to do only "technical" updates, minor bug fixes and optional additions on release branches, and use master as the main development branch. I think it will become messy if we start allowing the release branches to include development changes, so I would prefer a new release branch.

Once we remove MCT, I think it would make sense to start with release-2.0, so that release-1.X remains MCT-compatible also in the future.

@gold2718
Copy link

If the release-1.6 branch is already targeting NorESM2.3, what is a release-1.7 branch needed for?

@TomasTorsvik
Copy link
Contributor Author

If the release-1.6 branch is already targeting NorESM2.3, what is a release-1.7 branch needed for?

If we make a branch release-1.7, it would be a replacement for release-1.6, targeting NorESM2.3.

@gold2718
Copy link

If the release-1.6 branch is already targeting NorESM2.3, what is a release-1.7 branch needed for?

If we make a branch release-1.7, it would be a replacement for release-1.6, targeting NorESM2.3.

Sorry for being slow, why not just update release-1.6 given that we are still working on the initial NorESM2.3 release?

@TomasTorsvik
Copy link
Contributor Author

If the release-1.6 branch is already targeting NorESM2.3, what is a release-1.7 branch needed for?

If we make a branch release-1.7, it would be a replacement for release-1.6, targeting NorESM2.3.

Sorry for being slow, why not just update release-1.6 given that we are still working on the initial NorESM2.3 release?

Not at all, I suppose it all comes down to naming conventions and what we think these should mean.

We had a discussion about naming convention about a year ago, in #295, and we have mostly followed the scheme outlined here after that, i.e. with a convention on naming the release branches of v[MAJOR].[MINOR].[PATCH]. I suppose we never defined exactly what goes into [MAJOR], [MINOR] and [PATCH], but in my mind a [PATCH] should be something fairly trivial.

What I like with doing it this way is that you can follow the progression of the code by looking only at the change logs associated with the vX.X.0 tags. So for this reason I would prefer to make a new branch release-1.7 with a well documented v1.7.0 tag rather than having the same content in a v1.6.6 tag.

The downside is that we will have more release branches, but I think we only need to actively maintain a few of those. The release branches release-1.0, release-1.2 and release-1.3 are stale and in a practical sense deprecated at this point. We should probably document this in some way, and eventually archive the stale branches.

@TomasTorsvik
Copy link
Contributor Author

I have now added an entry in issue #340 for development that we can put into a new v1.7.0 tag. Feel free to add/edit the list.

@TomasTorsvik TomasTorsvik pinned this issue Nov 29, 2024
@TomasTorsvik TomasTorsvik moved this from Todo to In Progress in NorESM Development Dec 20, 2024
@jmaerz
Copy link
Collaborator

jmaerz commented Jan 17, 2025

I suspect that this issue could be rename to NorESM version 2.5? (and be closed soon)

@TomasTorsvik TomasTorsvik changed the title New BLOM/iHAMOCC release-1.7 branch for NorESM2.3? New BLOM/iHAMOCC release-1.7 branch for NorESM2.5? Jan 17, 2025
@TomasTorsvik
Copy link
Contributor Author

@jmaerz , @JorgSchwinger , @matsbn , @milicak
I will go ahead and prepare the v1.7 release now.

@jmaerz jmaerz unpinned this issue Jan 17, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in NorESM Development Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code release Issues related to upcoming code release or tagging
Projects
Status: Done
Development

No branches or pull requests

6 participants