Fix plugin dependency checks and set npmPackage values on plugins #6046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
schaable
added
status:ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #6035
The original scope of the issue was to set the
npmPackageproperty of our hardhat3 plugins, so when an import fails we can give detailed information if a given plugin package is missing, or some of its peer dependencies.When running a test scenario, specifically using
hardhat-viemand not having theviempeer dep installed, I noticed that even after setting thenpmPackageproperty on our plugin, the error message wasn't helping. This lead me to debug the coreplugins/detect-plugin-npm-dependency-problems.tsmodule.I noticed that the
require.resolvefunction was not working, and after thorough debugging I found out that thecreateRequirefunction doesn't work properly when passing an absolute path to a directory without a trailing forward slash. Adding the trailing forward slash to the directory path would make therequireinstance work.After that, I started to get the error that
package.jsonwas not being exported by our modules, and we need torequire()those to find the peer dependencies of packages. Then I added an export ofpackage.jsonto all of our modules.Closes #6035