From a37b2512ab0f8ca0479b20e69fba2bcead6f3d44 Mon Sep 17 00:00:00 2001 From: zoeyTM Date: Thu, 16 Jan 2025 03:29:20 -0500 Subject: [PATCH] all ignition packages linting successfully --- .../src/internal/journal/memory-journal.ts | 6 +++--- .../new-api/internal/new-execution/jsonrpc-client.ts | 6 +++--- packages/hardhat-ignition-core/test/execution/abi.ts | 4 ++-- packages/hardhat-ignition-ethers/README.md | 3 +-- packages/hardhat-ignition-viem/README.md | 3 +-- packages/hardhat-ignition/README.md | 3 +-- 6 files changed, 11 insertions(+), 14 deletions(-) diff --git a/packages/hardhat-ignition-core/src/internal/journal/memory-journal.ts b/packages/hardhat-ignition-core/src/internal/journal/memory-journal.ts index 56a2cc83bb..773e9dbfdd 100644 --- a/packages/hardhat-ignition-core/src/internal/journal/memory-journal.ts +++ b/packages/hardhat-ignition-core/src/internal/journal/memory-journal.ts @@ -10,18 +10,18 @@ import { emitExecutionEvent } from "./utils/emitExecutionEvent"; * @beta */ export class MemoryJournal implements Journal { - private messages: JournalMessage[] = []; + private _messages: JournalMessage[] = []; constructor(private _executionEventListener?: ExecutionEventListener) {} public record(message: JournalMessage): void { this._log(message); - this.messages.push(message); + this._messages.push(message); } public async *read(): AsyncGenerator { - for (const message of this.messages) { + for (const message of this._messages) { yield message; } } diff --git a/packages/hardhat-ignition-core/test-integrations/new-api/internal/new-execution/jsonrpc-client.ts b/packages/hardhat-ignition-core/test-integrations/new-api/internal/new-execution/jsonrpc-client.ts index ce35d7fbe6..6d4a176922 100644 --- a/packages/hardhat-ignition-core/test-integrations/new-api/internal/new-execution/jsonrpc-client.ts +++ b/packages/hardhat-ignition-core/test-integrations/new-api/internal/new-execution/jsonrpc-client.ts @@ -53,7 +53,7 @@ describe("JSON-RPC client", function () { return { artifact, address: receipt!.contractAddress! }; } - describe("getChainId", async function () { + describe("getChainId", function () { it("Should return the chainId as number", async function () { const chainId = await client.getChainId(); @@ -61,7 +61,7 @@ describe("JSON-RPC client", function () { }); }); - describe("getLatestBlock", async function () { + describe("getLatestBlock", function () { it("Should return the first block in the correct format", async function () { const block = await client.getLatestBlock(); @@ -80,7 +80,7 @@ describe("JSON-RPC client", function () { }); }); - describe("getNetworkFees", async function () { + describe("getNetworkFees", function () { describe("With an EIP-1559 network (i.e. Hardhat Network)", function () { it("Should return information about EIP-1559 fees", async function () { const fees = await client.getNetworkFees(); diff --git a/packages/hardhat-ignition-core/test/execution/abi.ts b/packages/hardhat-ignition-core/test/execution/abi.ts index 7d0697a780..a90d6ca3c4 100644 --- a/packages/hardhat-ignition-core/test/execution/abi.ts +++ b/packages/hardhat-ignition-core/test/execution/abi.ts @@ -507,7 +507,7 @@ describe("abi", () => { }); }); - describe("When the function returns something and there's no clash", async () => { + describe("When the function returns something and there's no clash", () => { it("should return RevertWithoutReason", async () => { const { decoded } = decode("C", "revertWithoutReasonWithoutClash"); assert.deepEqual(decoded, { @@ -631,7 +631,7 @@ describe("abi", () => { }); }); - describe("When the function returns something and there's no clash", async () => { + describe("When the function returns something and there's no clash", () => { it("should return RevertWithoutReason", async () => { const { decoded } = decode("C", "invalidOpcode"); assert.deepEqual(decoded, { diff --git a/packages/hardhat-ignition-ethers/README.md b/packages/hardhat-ignition-ethers/README.md index 5d0862da2d..b6e1fa32e4 100644 --- a/packages/hardhat-ignition-ethers/README.md +++ b/packages/hardhat-ignition-ethers/README.md @@ -1,5 +1,4 @@ -![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f) -[![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org) +![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f) [![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org) --- diff --git a/packages/hardhat-ignition-viem/README.md b/packages/hardhat-ignition-viem/README.md index 071aab7b97..a171504942 100644 --- a/packages/hardhat-ignition-viem/README.md +++ b/packages/hardhat-ignition-viem/README.md @@ -1,5 +1,4 @@ -![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f) -[![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition-viem.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org) +![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f) [![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition-viem.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org) --- diff --git a/packages/hardhat-ignition/README.md b/packages/hardhat-ignition/README.md index 8c405ab605..7acbb2377a 100644 --- a/packages/hardhat-ignition/README.md +++ b/packages/hardhat-ignition/README.md @@ -1,5 +1,4 @@ -![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f) -[![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org) [![Open in Dev Containers](https://img.shields.io/static/v1?label=Dev%20Containers&message=Open&color=blue&logo=visualstudiocode)](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/NomicFoundation/hardhat-ignition.git) +![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f) [![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org) [![Open in Dev Containers](https://img.shields.io/static/v1?label=Dev%20Containers&message=Open&color=blue&logo=visualstudiocode)](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/NomicFoundation/hardhat-ignition.git) ---