Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Arc<RwLock> from build model types in edr_solidity #759

Open
agostbiro opened this issue Dec 31, 2024 · 0 comments
Open

Remove Arc<RwLock> from build model types in edr_solidity #759

agostbiro opened this issue Dec 31, 2024 · 0 comments

Comments

@agostbiro
Copy link
Member

agostbiro commented Dec 31, 2024

In #734 we switched to Arc<RwLock> in build model types instead of Rc<RefCell> in edr_solidity. This was necessary, because the EDR provider holds on to those types now to support hardhat_addCompilationResult, so they need to be Send.

Definition of Done

We don't really need to write to the types held by Arc<RwLock> outside the edr_solidity crate, so ideally we would switch back to Rc<RefCell> internally and then expose build model types without interior mutability. Note that this is difficult to achieve, because there are always at least two references to contract structs after interior mutability is no longer needed (one in the deployed contract and one in the deployment contract).

@github-project-automation github-project-automation bot moved this to Unconfirmed in EDR Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Inbox
Development

No branches or pull requests

1 participant