You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #734 we switched to Arc<RwLock> in build model types instead of Rc<RefCell> in edr_solidity. This was necessary, because the EDR provider holds on to those types now to support hardhat_addCompilationResult, so they need to be Send.
Definition of Done
We don't really need to write to the types held by Arc<RwLock> outside the edr_solidity crate, so ideally we would switch back to Rc<RefCell> internally and then expose build model types without interior mutability. Note that this is difficult to achieve, because there are always at least two references to contract structs after interior mutability is no longer needed (one in the deployed contract and one in the deployment contract).
The text was updated successfully, but these errors were encountered:
In #734 we switched to
Arc<RwLock>
in build model types instead ofRc<RefCell>
inedr_solidity
. This was necessary, because the EDR provider holds on to those types now to supporthardhat_addCompilationResult
, so they need to beSend
.Definition of Done
We don't really need to write to the types held by
Arc<RwLock>
outside theedr_solidity
crate, so ideally we would switch back toRc<RefCell>
internally and then expose build model types without interior mutability. Note that this is difficult to achieve, because there are always at least two references to contract structs after interior mutability is no longer needed (one in the deployed contract and one in the deployment contract).The text was updated successfully, but these errors were encountered: