Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IMPORT FAILED): comfyui-popup_preview #3

Open
MNeMoNiCuZ opened this issue Dec 26, 2023 · 13 comments
Open

(IMPORT FAILED): comfyui-popup_preview #3

MNeMoNiCuZ opened this issue Dec 26, 2023 · 13 comments

Comments

@MNeMoNiCuZ
Copy link

I can't seem to install this at all, I've retried several times. Both by installing missing nodes, and manually installing from this repo.

When restarting Comfy, I get this in my import custom nodes section:
(IMPORT FAILED): C:\AI\ComfyUI\custom_nodes\comfyui-popup_preview

In the workflow, I get this:
image

And in "Install missing nodes", I get this:
image

I have tried to uninstall and reinstall from there, it's just not starting with Comfy.
The files are downloaded fine.
I have tried running the setup.bat as well.

Any suggestions?

@uoo2
Copy link

uoo2 commented Dec 26, 2023

same problem :(

@ViratX
Copy link

ViratX commented Dec 27, 2023

1+ same problem

@NimaNzrii
Copy link
Owner

could you please send whole error?

@MNeMoNiCuZ
Copy link
Author

In the console when trying to run the workflow:

Starting server

To see the GUI go to: http://127.0.0.1:8188
FETCH DATA from: C:\AI\ComfyUI\custom_nodes\ComfyUI-Manager\extension-node-map.json
Error: OpenAI API key is invalid OpenAI features wont work for you
QualityOfLifeSuit_Omar92::NSP ready
[comfy_mtb] | WARNING -> Found multiple match, we will pick the first C:\AI\ComfyUI\models\upscale_models
['C:\\AI\\ComfyUI\\models\\upscale_models', 'C:\\AI\\stable-diffusion-webui\\models/ESRGAN', 'C:\\AI\\stable-diffusion-webui\\models/RealESRGAN', 'C:\\AI\\stable-diffusion-webui\\models/SwinIR']
[comfy_mtb] | WARNING -> No Face Restore checkpoints found at C:\AI\ComfyUI\models\face_restore (if you've used mtb before these checkpoints were saved in upscale_models before)
[comfy_mtb] | WARNING -> For now we fallback to upscale_models but this will be removed in a future version
Error handling request
Traceback (most recent call last):
  File "C:\Users\MNeMiC\AppData\Roaming\Python\Python311\site-packages\aiohttp\web_protocol.py", line 452, in _handle_request
    resp = await request_handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\MNeMiC\AppData\Roaming\Python\Python311\site-packages\aiohttp\web_app.py", line 543, in _handle
    resp = await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\MNeMiC\AppData\Roaming\Python\Python311\site-packages\aiohttp\web_middlewares.py", line 114, in impl
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "C:\AI\ComfyUI\server.py", line 46, in cache_control
    response: web.Response = await handler(request)
                             ^^^^^^^^^^^^^^^^^^^^^^
  File "C:\AI\ComfyUI\custom_nodes\comfyui-workspace-manager\__init__.py", line 233, in update_file
    file.write(json_str)
  File "C:\Python311\Lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeEncodeError: 'charmap' codec can't encode characters in position 2531-2532: character maps to <undefined>

Importing of node when launching:
0.0 seconds (IMPORT FAILED): C:\AI\ComfyUI\custom_nodes\comfyui-popup_preview

image

@ViratX
Copy link

ViratX commented Dec 28, 2023

Yes, this above screen shot is exactly what I get as the error message. I've tried installing it through Comfy Manager as well as Git Clone.

@NimaNzrii
Copy link
Owner

Are you using portable version of comfyui?

@MNeMoNiCuZ
Copy link
Author

No, the github cloned version.
All up-to-date yesterday before I posted my last message.

@uoo2
Copy link

uoo2 commented Dec 28, 2023

No, the github cloned version. All up-to-date yesterday before I posted my last message.

me too, same cloned version

@ViratX
Copy link

ViratX commented Dec 28, 2023 via email

@K-O-N-B
Copy link

K-O-N-B commented Dec 29, 2023

same problem, please fix it

@NimaNzrii
Copy link
Owner

The issue's resolved, you've updated, and now enjoy! 💖
The problem was in the non-portable versions of Comfy UI, which were sending the wrong return address. This got fixed by changing the library.

@MNeMoNiCuZ
Copy link
Author

Great! Confirmed to work for me, I took a full Comfy update and it all just worked (loading the node pack, I haven't tried using it yet).

Great job!

@ronaldluka
Copy link

I still can't get it to work. Here is a copy of the error code.
I have the portable version

Error occurred when executing PreviewPopup:

PreviewPopup.() takes 0 positional arguments but 1 was given

File "I:\ComfyUI\ComfyUI\execution.py", line 152, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "I:\ComfyUI\ComfyUI\execution.py", line 82, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "I:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_ezXY\autoCastPatch.py", line 265, in map_node_over_list
_info = obj.INPUT_TYPES()
^^^^^^^^^^^^^^^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants