Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Nicolapps,
I finally managed to have a working implementation for the clustering. The solution is not perfect, but it I tried many things and this ended to be the most reliant and easy to maintain solution. Technically what it does is return an empty cluster annotation and implementing a new Annotation with the cluster coordinates. I implemented a hook to get the coordinates so it should be easy to implement it by the user. That way we can reuse our Annotation component and do not have to do a complete re-implementation as the
annotationForCluster
function expects to be returned the MapKit Annotation and not a DOM element and we do not need to do a complete re-implementation of our Annotation and Marker component where we would need to return the component instead of attaching it to the map while also handling the createPortal stuff for the React part.Let me know what you think about it, I would be happy about a review and can also do some cleanup of the code and example if this is the variant we are agreeing on!
fixes #61
Edit: There is still a major issue in unmounting the cluster annotations unfortunately, not sure if it is possible to fix with the current implementation or if I need to go for another variant. I cannot mark the PR as draft.