From 3e9227a966c0bc3af9a83df78d5d00da595f478b Mon Sep 17 00:00:00 2001 From: Nick Logozzo Date: Mon, 6 Nov 2023 16:31:13 -0500 Subject: [PATCH 01/14] Start Next Ver --- NickvisionTagger.Shared/Models/MusicFile.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/NickvisionTagger.Shared/Models/MusicFile.cs b/NickvisionTagger.Shared/Models/MusicFile.cs index 2ba8c7fe..bf2444ef 100644 --- a/NickvisionTagger.Shared/Models/MusicFile.cs +++ b/NickvisionTagger.Shared/Models/MusicFile.cs @@ -88,6 +88,7 @@ static MusicFile() else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux)) { _invalidSystemFilenameCharacters.Remove('/'); + _invalidWindowsFilenameCharacters.Remove('/'); } SortFilesBy = SortBy.Path; LimitFilenameCharacters = false; From 8916beae29e51b5525c92598ff4a2631c27bd71c Mon Sep 17 00:00:00 2001 From: Nick Logozzo Date: Mon, 6 Nov 2023 16:31:21 -0500 Subject: [PATCH 02/14] Start Next Ver --- NickvisionTagger.GNOME/Program.cs | 5 +---- .../Controllers/MainWindowController.cs | 2 +- .../org.nickvision.tagger.metainfo.xml.in | 7 ++----- NickvisionTagger.WinUI/App.xaml.cs | 6 +----- 4 files changed, 5 insertions(+), 15 deletions(-) diff --git a/NickvisionTagger.GNOME/Program.cs b/NickvisionTagger.GNOME/Program.cs index 1a4a371e..837da403 100644 --- a/NickvisionTagger.GNOME/Program.cs +++ b/NickvisionTagger.GNOME/Program.cs @@ -33,10 +33,7 @@ public Program(string[] args) _mainWindow = null; _mainWindowController = new MainWindowController(args); _mainWindowController.AppInfo.Changelog = - @"* Added the ability to specify ""/"" in a Tag to File Name format string to move files to a new directory when renaming files - * Tagger now has the ability to fix corrupted file right from within the app - * Tagger will now display files with corrupted album art as corrupted files - * Fixed an issue where some custom properties for vorbis and wav files could not be removed + @"* Fixed an issue where specifying the directory separator in Tag to File Name when Limit Filename Characters was enabled caused new directories to not be made * Updated translations (Thanks everyone on Weblate!)"; _application.OnActivate += OnActivate; if (File.Exists(Path.GetFullPath(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location)) + "/org.nickvision.tagger.gresource")) diff --git a/NickvisionTagger.Shared/Controllers/MainWindowController.cs b/NickvisionTagger.Shared/Controllers/MainWindowController.cs index d34343d1..f1661e53 100644 --- a/NickvisionTagger.Shared/Controllers/MainWindowController.cs +++ b/NickvisionTagger.Shared/Controllers/MainWindowController.cs @@ -164,7 +164,7 @@ public MainWindowController(string[] args) } Aura.Active.SetConfig("config"); Configuration.Current.Saved += ConfigurationSaved; - AppInfo.Version = "2023.11.1"; + AppInfo.Version = "2023.11.2-next"; AppInfo.ShortName = _("Tagger"); AppInfo.Description = _("Tag your music"); AppInfo.SourceRepo = new Uri("https://github.com/NickvisionApps/Tagger"); diff --git a/NickvisionTagger.Shared/org.nickvision.tagger.metainfo.xml.in b/NickvisionTagger.Shared/org.nickvision.tagger.metainfo.xml.in index 5f0c08eb..ad943896 100644 --- a/NickvisionTagger.Shared/org.nickvision.tagger.metainfo.xml.in +++ b/NickvisionTagger.Shared/org.nickvision.tagger.metainfo.xml.in @@ -39,12 +39,9 @@ org.nickvision.tagger - + -

- Added the ability to specify ""/"" in a Tag to File Name format string to move files to a new directory when renaming files

-

- Tagger now has the ability to fix corrupted file right from within the app

-

- Tagger will now display files with corrupted album art as corrupted files

-

- Fixed an issue where some custom properties for vorbis and wav files could not be removed

+

- Fixed an issue where specifying the directory separator in Tag to File Name when Limit Filename Characters was enabled caused new directories to not be made

- Updated translations (Thanks everyone on Weblate!)

 diff --git a/NickvisionTagger.WinUI/App.xaml.cs b/NickvisionTagger.WinUI/App.xaml.cs index a91afd0b..d6b90624 100644 --- a/NickvisionTagger.WinUI/App.xaml.cs +++ b/NickvisionTagger.WinUI/App.xaml.cs @@ -23,11 +23,7 @@ public App() InitializeComponent(); _controller = new MainWindowController(Array.Empty()); _controller.AppInfo.Changelog = - @"- Added the ability to specify ""\"" in a Tag to File Name format string to move files to a new directory when renaming files -- Tagger now has the ability to fix corrupted file right from within the app -- Tagger will now display files with corrupted album art as corrupted files -- Fixed an issue where some custom properties for vorbis and wav files could not be removed -- Updated translations (Thanks everyone on Weblate!)"; + @"- Updated translations (Thanks everyone on Weblate!)"; if (_controller.Theme != Theme.System) { RequestedTheme = _controller.Theme switch From 8bb0707c38a2671682bf2997c24dd68f3383a760 Mon Sep 17 00:00:00 2001 From: Nick Logozzo Date: Mon, 6 Nov 2023 16:37:36 -0500 Subject: [PATCH 03/14] WInUI - Improve LyricsDialog UX --- NickvisionTagger.WinUI/App.xaml.cs | 3 ++- NickvisionTagger.WinUI/Controls/SyncLyricRow.xaml | 6 ------ .../Controls/SyncLyricRow.xaml.cs | 13 +++---------- NickvisionTagger.WinUI/Views/LyricsDialog.xaml.cs | 2 +- 4 files changed, 6 insertions(+), 18 deletions(-) diff --git a/NickvisionTagger.WinUI/App.xaml.cs b/NickvisionTagger.WinUI/App.xaml.cs index d6b90624..54580ee2 100644 --- a/NickvisionTagger.WinUI/App.xaml.cs +++ b/NickvisionTagger.WinUI/App.xaml.cs @@ -23,7 +23,8 @@ public App() InitializeComponent(); _controller = new MainWindowController(Array.Empty()); _controller.AppInfo.Changelog = - @"- Updated translations (Thanks everyone on Weblate!)"; + @"- Improved the UX of the LyricsDialog +- Updated translations (Thanks everyone on Weblate!)"; if (_controller.Theme != Theme.System) { RequestedTheme = _controller.Theme switch diff --git a/NickvisionTagger.WinUI/Controls/SyncLyricRow.xaml b/NickvisionTagger.WinUI/Controls/SyncLyricRow.xaml index 4a89b96a..aa51bfb0 100644 --- a/NickvisionTagger.WinUI/Controls/SyncLyricRow.xaml +++ b/NickvisionTagger.WinUI/Controls/SyncLyricRow.xaml @@ -13,12 +13,6 @@ - -