Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Invalidation of typical session ID #1819

Closed
3 tasks done
CodyCBakerPhD opened this issue Jan 11, 2024 · 2 comments
Closed
3 tasks done

[Bug]: Invalidation of typical session ID #1819

CodyCBakerPhD opened this issue Jan 11, 2024 · 2 comments
Assignees
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users topic: HDMF issues related to the use, depending on, or affecting HDMF topic: validator issues related to validation of files

Comments

@CodyCBakerPhD
Copy link
Collaborator

What happened?

Very strange/silly bug just discovered by the JazLab; not sure how long this has technically been around (I usually use underscores in session IDs personally)

Steps to Reproduce

from pynwb.testing.mock.file import mock_NWBFile
from pynwb import NWBHDF5IO

with NWBHDF5IO(path=".../Downloads/test_invalid.nwb.hdf5", mode="w") as io:
    io.write(mock_NWBFile(session_id="2024-01-01"))

Traceback

- found the following errors:
root/general/session_id (general/session_id): incorrect type - expected 'text', got 'isodatetime'

Operating System

Windows

Python Executable

Conda

Python Version

3.11

Package Versions

No response

Code of Conduct

@rly
Copy link
Contributor

rly commented Jan 11, 2024

This looks like an issue with the validator. I'll create a ticket on HDMF.

@rly rly added category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users topic: HDMF issues related to the use, depending on, or affecting HDMF topic: validator issues related to validation of files labels Jan 11, 2024
@rly rly self-assigned this Jan 12, 2024
@rly
Copy link
Contributor

rly commented Jan 13, 2024

This has been fixed in hdmf-dev/hdmf#1026 and will be available in the next HDMF release sometime next week.

@rly rly closed this as completed Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users topic: HDMF issues related to the use, depending on, or affecting HDMF topic: validator issues related to validation of files
Projects
None yet
Development

No branches or pull requests

2 participants