Allow validating timezone with Inspector calls #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…urodataWithoutBorders/nwb-guide into inspector-timezone-validation
for more information, see https://pre-commit.ci
…urodataWithoutBorders/nwb-guide into inspector-timezone-validation
|
Would you recommend this get merged before or after the parent? |
|
Hmm depends on your answer to this question. With any timezone awareness, we have to decide how we want to limit the user's selection of future dates—if at all. Right now, the date selector uses the current time in local time—but this isn't timezone aware so, for instance, I would not be able to choose a future time tomorrow for a project run in Europe. This is a general problem across both PRs. Though the consequences are limited by Ben's earlier note that data from different timezones will rarely be converted the same day. |
|
Yeah that's really an edge case so I'll check this out in more detail tomorrow |
CodyCBakerPhD
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses NeurodataWithoutBorders/nwbinspector#471 to properly validate timezone with Inspector checks.