Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent interruption of AcToolStartupHookServiceImpl #778

Open
kwin opened this issue Jan 21, 2025 · 0 comments
Open

Prevent interruption of AcToolStartupHookServiceImpl #778

kwin opened this issue Jan 21, 2025 · 0 comments

Comments

@kwin
Copy link
Member

kwin commented Jan 21, 2025

The underlying Felix SCR implementation waits at most 5 seconds (https://github.com/apache/felix-dev/blob/38543865717f8b9228243cafd75045c6ad2ea02e/scr/src/main/java/org/apache/felix/scr/impl/manager/ScrConfiguration.java#L60) until it interrupts activate methods of DS components. Also there is known race conditions (https://issues.apache.org/jira/browse/FELIX-5612), therefore we should probably
a) should always run asynchronously and
b) find a way to defer shutting down AEM during the image build
for the ACToolStartupHookServiceImpl (https://github.com/Netcentric/accesscontroltool/blob/develop/accesscontroltool-startuphook-bundle/src/main/java/biz/netcentric/cq/tools/actool/startuphook/impl/AcToolStartupHookServiceImpl.java#L99) until a) is finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant