Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Nebulius/grav-plugin-static-social-embeds
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.2
Choose a base ref
...
head repository: Nebulius/grav-plugin-static-social-embeds
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref

Commits on Aug 23, 2018

  1. Copy the full SHA
    d3c145a View commit details
  2. Updated CHANGELOG

    AmauryCarrade committed Aug 23, 2018
    Copy the full SHA
    8979e85 View commit details

Commits on Apr 21, 2019

  1. Copy the full SHA
    4ab827e View commit details
  2. Fixed administration form rendering bug with English language.

    The translation files for the English language were not consistant with the
    referenced keys in the blueprints, leading to array-to-string conversions. The
    files were updated to use the same structure and the blueprint was modified
    to match the English files, as it was better.
    
    Probably an unfinished change that was commited erroneously.
    
    Fixes #1.
    AmauryCarrade committed Apr 21, 2019
    Copy the full SHA
    042a160 View commit details
  3. Copy the full SHA
    6e59859 View commit details
  4. Updated styles and fixed video playing in the background while switch…

    …ing to next media.
    
    - Improved margins around the embeds.
    - If a video is playing and the user switch to the next media, it is stopped.
    - Updated Makefile for the new standard dart-sass.
    AmauryCarrade committed Apr 21, 2019
    Copy the full SHA
    19e35d0 View commit details
  5. Improved errors styles.

    AmauryCarrade committed Apr 21, 2019
    Copy the full SHA
    a75c707 View commit details
  6. Version 1.1.1

    - Updated version number
    - Updated README + details
    - Rebuilt CSS
    AmauryCarrade committed Apr 21, 2019
    Copy the full SHA
    25dd280 View commit details
  7. Copy the full SHA
    5fec5a3 View commit details
  8. Updated changelog

    Forgot that…
    AmauryCarrade authored Apr 21, 2019
    Copy the full SHA
    8d62c12 View commit details
  9. Version 1.1.4.1

    AmauryCarrade authored Apr 21, 2019
    Copy the full SHA
    40db827 View commit details

Commits on Apr 22, 2019

  1. Fixed Mastodon medias not downloaded even if setting is enabled.

    Medias were downloaded, but the URLs were incorrectly saved to the cached toot, as the remote
    URLs were kept by mistake. This has been resolved.
    
    Closes #2.
    AmauryCarrade committed Apr 22, 2019
    Copy the full SHA
    27de887 View commit details
  2. Added support for Mastodon custom emojis in display names.

    - Added support for Mastodon custom emojis in display names, with downloads of course.
    - Improved accessibility of the embeds.
    - Updated Twitter embeds to match closely the real ones.
    - Centering fixes on some themes.
    AmauryCarrade committed Apr 22, 2019
    Copy the full SHA
    f848324 View commit details
  3. Copy the full SHA
    5514b71 View commit details
  4. Updated README

    AmauryCarrade committed Apr 22, 2019
    Copy the full SHA
    59b0603 View commit details
  5. Copy the full SHA
    385d5d4 View commit details
  6. Copy the full SHA
    b6bd1ee View commit details
  7. Version 1.1.5

    AmauryCarrade committed Apr 22, 2019
    Copy the full SHA
    b84a0cb View commit details

Commits on Feb 16, 2020

  1. Fix issue around "Class 'Grav\Plugin\Shortcodes\Shortcode' not found".

    This patch fixes #4.
    
    Context:
    
        Before this patch (after 4.2.0 of shortcode-core), I could
        not run Grav (bin/grav and webserver) anymore.
    
        Indeed, I got "Class 'Grav\Plugin\Shortcodes\Shortcode' not found"
        as error and asked for help on the discord server of the
        Grav Core Team.
    
        @mahagr & @rhukster tried to help me with a patch+release
        (shortcode-core 4.2.1) but it still did not solve the issue.
        So I decided to fix it myself.
    
    Resolution:
    
        I first followed the new structure by moving the shortcodes classes
        inside the `classes` directory.
        Same for `classes/SSEShortcode.php` which I moved to
        `classes/plugin/SSEShortcode.php`.
    
        In the `static-social-embeds.php` file, I just fixed the autoloader.
        In particularly the `getSubscribedEvents()` method. From now,
        `classes/plugin/SSEShortcode.php` is only loaded when we are not
        in the admin section.
    
        After, applying and testing those changes, onto my fresh development
        environment (latest grav-admin+docker-compose), everything worked
        back properly.
    funilrys committed Feb 16, 2020
    Copy the full SHA
    d19349c View commit details

Commits on Feb 21, 2020

  1. Fix issues mentionned by @mahagr's review.

    Indeed, I was not using composer to autoload everything which is needeed.
    
    Also:
      * Reverse changes regarding the files locations.
    funilrys committed Feb 21, 2020
    Copy the full SHA
    59f41db View commit details

Commits on Jul 26, 2020

  1. Merge pull request #5 from funilrys/shortcode-not-found

    Fix issue around "Class 'Grav\Plugin\Shortcodes\Shortcode' not found".
    AmauryCarrade authored Jul 26, 2020
    Copy the full SHA
    f89959d View commit details
  2. Version 1.1.6

    AmauryCarrade committed Jul 26, 2020
    Copy the full SHA
    212ba4c View commit details
36 changes: 36 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,39 @@
# v1.1.6
## 26-07-2020

1. [](#bugfix)
* Fixed “ProblemChecker class not found” due to bad classes autoload ([#5](https://github.com/Nebulius/grav-plugin-static-social-embeds/pull/5), thanks to funilrys!).

# v1.1.5
## 22-04-2019

1. [](#bugfix)
* Fixed Matodon medias not correctly downloaded (they were downloaded, but the local copy was not used).
* Fixed Mastodon's custom emojis not correclty supported (they are now correctly displayed in spoiler texts and display names).
1. [](#improved)
* Improved some embeds stylings to match their models.
* Improved compatibility with some themes.
* Improved embeds accessibility a little bit.

# v1.1.4
## 21-04-2019

1. [](#bugfix)
* Fixed plugin admin rendering error in English, because the blueprint referred translation files with an inconsistent format (#1).
* Miscellaneous minor fixes and improvements.
1. [](#improved)
* Improved styles and in-flow integration (margins…).
* Improved video playing:
* the video will stop if the user switches to the next image;
* the controls are not under the navigation links.
* Updated documentation for new Twitter developer accounts.

# v1.1.3
## 23-08-2018

1. [](#bugfix)
* Fixed error while embedding non-existant Instagram post.

# v1.1.2
## 14-08-2018

4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
styles:
sass -t compressed --sourcemap=auto --unix-newlines assets/scss/sse.scss > assets/css-compiled/sse.min.css
sass -s compressed --no-source-map assets/scss/sse.scss > assets/css-compiled/sse.min.css

watch:
sass -t compressed --watch assets/scss/sse.scss:assets/css-compiled/sse.min.css
sass -s compressed --source-map --watch assets/scss/sse.scss:assets/css-compiled/sse.min.css
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -107,12 +107,15 @@ Themes can be `light` or `dark` as for now and for the built-in CSS. If you want

To use Twitter embeds, you'll need to register an application. This is done in a few simple steps.

1. Go to [the Twitter Apps page](https://apps.twitter.com/app/new) to create an application. You don't need to provide a callback URL (we never use that).
1. Go to [the Twitter Apps page](https://developer.twitter.com/en/apps) to create an application. You don't need to provide a callback URL (we never use that).
2. Then, click the **Keys and access tokens** tab and at the bottom of the page, click **Create my Access Token**.
3. Finally, copy the credentials in the configuration file (or in the admin).

If not configured, you'll see an error if you try to embed a tweet, but other embeds will work fine.

If you don't have a developer account, you'll have to [apply for one](https://developer.twitter.com/en/apply). Twitter will ask you how you plan to use the API.
For reference, this plugin uses it read-only and complies with Twitter's Guidelines regarding tweets integration.

### Customization

If you want to customize the embeds' HTML code, you can override the `partials/static-social-embeds` templates. The template name is the same as the shortcode name (see below), e.g. `toot.html.twig` for Mastodon embeds template. Templates context vary for different social networks; checkout built-in templates or shortcode classes to know which variables you can use.
@@ -146,9 +149,9 @@ The plugin is translated in English and French.

## Technical considerations regarding Instagram

While Twitter and Mastodon/Pleroma data are retrieved using their respective API, there is no way to do that with Instagram (or there is, but deprecated and soon-to-be-removed in december 2018). We scrap an internal JSON embed in the post pages to retrieve data (thanks to [RSSBridge](https://github.com/RSS-Bridge/rss-bridge/blob/master/bridges/InstagramBridge.php) for the tip). As it isn't official, it may break anytime.
While Twitter and Mastodon/Pleroma data are retrieved using their respective API, there is no way to do that with Instagram (the API was removed in december 2018). We scrap an internal JSON embed in the post pages to retrieve data (thanks to [RSSBridge](https://github.com/RSS-Bridge/rss-bridge/blob/master/bridges/InstagramBridge.php) for the tip). As it isn't official, it may break anytime.

Data is cached without expiration, so as long as you don't delete the cache, existing embeds will never break. New ones will. Feel free to open an issue if such problem occurs (but this is pretty stable for a few years now and I hope it will remains as such).
Data is cached without expiration, so as long as you don't fully delete the cache using the _all_ method, existing embeds will never break. New ones will. Feel free to open an issue if such problem occurs (but this is pretty stable for a few years now and I hope it will remains as such).

## Thanks

Loading