Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proc/cpuinfo for hardware serial #496

Closed
KevinWassermann94 opened this issue Mar 6, 2023 · 3 comments
Closed

Use proc/cpuinfo for hardware serial #496

KevinWassermann94 opened this issue Mar 6, 2023 · 3 comments

Comments

@KevinWassermann94
Copy link
Contributor

KevinWassermann94 commented Mar 6, 2023 •
edited by kashifpk
Loading

Acceptance Criteria:

  • Use /proc/cpuinfo for hardware serial mainly
  • Use current path (/proc/device-tree/serial-number) as backup
pritamghanghas pushed a commit that referenced this issue Mar 6, 2023
fix: Use proc/cpuinfo for hardware serial #496
512546d
pritamghanghas pushed a commit that referenced this issue Mar 6, 2023
fix: Use proc/cpuinfo for hardware serial #496
bc613ad
@pritamghanghas pritamghanghas mentioned this issue Mar 6, 2023
Merged
4 tasks
pritamghanghas added a commit that referenced this issue Mar 6, 2023
@pritamghanghas
Merge pull request #497 from NebraLtd/pritam/fix_serial_number
48b92ae 
fix: Use proc/cpuinfo for hardware serial #496
@pritamghanghas pritamghanghas mentioned this issue Mar 6, 2023
Merged
4 tasks
pritamghanghas pushed a commit that referenced this issue Mar 6, 2023
fix: Use proc/cpuinfo for hardware serial #496
85934e8 
* catch all possible exceptions while reading /proc/cpuinfo
@pritamghanghas pritamghanghas mentioned this issue Mar 6, 2023
Merged
4 tasks
@shawaj
Copy link
Member

shawaj commented Mar 6, 2023

Ref #206
Ref #219

pritamghanghas pushed a commit that referenced this issue Mar 6, 2023
fix: Use proc/cpuinfo for hardware serial #496
ca6f6c4 
* catch all possible exceptions while reading /proc/cpuinfo
pritamghanghas added a commit that referenced this issue Mar 6, 2023
@pritamghanghas
Merge pull request #498 from NebraLtd/pritam/fix_serial_number2
54a8478 
fix: Use proc/cpuinfo for hardware serial #496
This was referenced Mar 6, 2023
Closed
Merged
@pritamghanghas
Copy link
Contributor

this requies more work. if is there but all zero disregard that.

pritamghanghas pushed a commit that referenced this issue Mar 10, 2023
Use proc/cpuinfo for hardware serial #496
39e300f 
* disregard serial from /proc/cpuinfo if it is all zeros
@pritamghanghas pritamghanghas mentioned this issue Mar 10, 2023
Merged
4 tasks
pritamghanghas added a commit that referenced this issue Mar 10, 2023
@pritamghanghas
Merge pull request #499 from NebraLtd/pritam/disregard_all_zero_serial
23c6698 
Use proc/cpuinfo for hardware serial #496
This was referenced Mar 10, 2023
Merged
Merged
@shawaj shawaj mentioned this issue Mar 13, 2023
Merged
4 tasks
@shawaj
Copy link
Member

shawaj commented Mar 14, 2023

Closing this in favour of #507 as the fix is in. Just needs better tests

@shawaj shawaj closed this as completed Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shawaj @pritamghanghas @KevinWassermann94