-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of Global variables in $V, $L, $M, $P node package #6
Labels
Milestone
Comments
+1 |
1 similar comment
+1 |
+1 |
1 similar comment
+1 |
10 tasks
Also: the global addition of |
Hi all, I recently signed on as a maintainer of this project. I'll slate this for a stable 1.0.0 release 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there a reason that $V ,$L, $M, $P are in global scope? This is currently causing issues when testing with mocha, so we are having to add these to the mocha --globals option. Since everything is being exported it would seem like the attachment to global variable isn't required.
I assume there may be a very good reason for this but doesn't seem like best practice?
The text was updated successfully, but these errors were encountered: