Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadMisc/TestImagePCX fails #14

Open
devernay opened this issue Mar 25, 2021 · 12 comments
Open

ReadMisc/TestImagePCX fails #14

devernay opened this issue Mar 25, 2021 · 12 comments

Comments

@devernay
Copy link
Member

it gives a black image on linux and macOS
It was working OK in Natron 2.2.9

@rodlie
Copy link
Collaborator

rodlie commented Mar 26, 2021

Will take a look after work today.

@rodlie
Copy link
Collaborator

rodlie commented Mar 26, 2021

convert from the SDK is able to convert PCX, but reading a PCX in Natron results in a black image. If I build ReadMisc against system ImageMagick (6.9.10-23) then Natron reads the PCX file just fine.

@devernay
Copy link
Member Author

I guess this is what breaks PCX

@rodlie
Copy link
Collaborator

rodlie commented Mar 27, 2021

Changes in XCF does not break PCX.

@devernay
Copy link
Member Author

ah yes I mixed the letters ;-)

@devernay
Copy link
Member Author

Makes me think we could ship the IM utilities with Natron, just as we ship the oiio ones.

@rodlie
Copy link
Collaborator

rodlie commented Mar 27, 2021

Can't hurt.

I will try to find why PCX fails, but to be honest, does anyone care? it's an old relic from the DOS era, superseded by BMP.

@devernay
Copy link
Member Author

Makes me think we could ship the IM utilities with Natron, just as we ship the oiio ones.

And it would be even easier with IM7, which I think has only one utility (magick).

I'm OK if you disable PCX support in Natron (either at compile time or at run time)

@rodlie
Copy link
Collaborator

rodlie commented Mar 27, 2021

which I think has only one utility (magick).

Correct, you only need to prefix commands with magick.

magick convert, magick identify etc.

I'm OK if you disable PCX support in Natron (either at compile time or at run time)

Can do.

rodlie added a commit that referenced this issue Mar 27, 2021
If enabled adds supports for old legacy formats like PCX in ReadMisc.
@devernay
Copy link
Member Author

perhaps this has to do with the fact that your system IM has different HDRI/depth settings than Natron's?

@rodlie
Copy link
Collaborator

rodlie commented Mar 28, 2021

I tried Q16 with and without HDRI, same result. Can try with Q8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants