From 58d008edc50d90c310c9b5620eff7c083cc6339e Mon Sep 17 00:00:00 2001 From: NatLeong <> Date: Sun, 14 Apr 2024 02:58:58 +0800 Subject: [PATCH] Update remaining tests --- .../logic/commands/CheckCommandTest.java | 21 ++++++++++--------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/test/java/seedu/address/logic/commands/CheckCommandTest.java b/src/test/java/seedu/address/logic/commands/CheckCommandTest.java index 901d0692390..c6effeb9468 100644 --- a/src/test/java/seedu/address/logic/commands/CheckCommandTest.java +++ b/src/test/java/seedu/address/logic/commands/CheckCommandTest.java @@ -8,6 +8,7 @@ import static seedu.address.logic.commands.CommandTestUtil.assertCommandFailure; import static seedu.address.logic.commands.CommandTestUtil.assertCommandSuccess; import static seedu.address.testutil.TypicalPersons.ALICE; +import static seedu.address.testutil.TypicalPersons.DANIEL; import static seedu.address.testutil.TypicalVisits.VISIT_ALICE; import org.junit.jupiter.api.Test; @@ -26,7 +27,7 @@ public class CheckCommandTest { private final Model model = new ModelManager(TypicalVisits.getTypicalCombinedAddressBook(), new UserPrefs()); private final Model expectedModel = new ModelManager( TypicalVisits.getTypicalCombinedAddressBook(), new UserPrefs()); - /*@Test + @Test void execute_validVisitNric_success() { StringBuilder stringBuilder = new StringBuilder(); @@ -39,15 +40,15 @@ void execute_validVisitNric_success() { expectedModel.updateFilteredPersonList(new NricContainsKeywordsPredicate(VISIT_ALICE.getNric().toString())); expectedModel.updateFilteredVisitList(new VisitContainsNricPredicate(VISIT_ALICE.getNric().toString())); assertCommandSuccess(command, model, expectedMessage, expectedModel); - }*/ + } @Test - void execute_invalidVisitNric_success() { + void execute_noVisitNric_success() { StringBuilder stringBuilder = new StringBuilder(); - stringBuilder.append(ALICE.getName()).append(" (NRIC: ").append(ALICE.getNric()).append("):\n"); + stringBuilder.append(DANIEL.getName()).append(" (NRIC: ").append(DANIEL.getNric()).append("):\n"); String expectedMessage = String.format(MESSAGE_READ_PERSON_SUCCESS, stringBuilder); - CheckCommand command = new CheckCommand(ALICE.getNric()); - expectedModel.updateFilteredPersonList(new NricContainsKeywordsPredicate(ALICE.getNric().toString())); + CheckCommand command = new CheckCommand(DANIEL.getNric()); + expectedModel.updateFilteredPersonList(new NricContainsKeywordsPredicate(DANIEL.getNric().toString())); assertCommandSuccess(command, model, expectedMessage, expectedModel); } @@ -58,14 +59,14 @@ void execute_nonExistentNric_failure() { @Test void equals() { - CheckCommand checkFirstCommand = new CheckCommand(ALICE.getNric()); + CheckCommand checkFirstCommand = new CheckCommand(VISIT_ALICE.getNric()); CheckCommand checkSecondCommand = new CheckCommand(new Nric(NON_EXISTENT_NRIC)); // same object -> returns true assertTrue(checkFirstCommand.equals(checkFirstCommand)); // same values -> returns true - CheckCommand checkFirstCommandCopy = new CheckCommand(ALICE.getNric()); + CheckCommand checkFirstCommandCopy = new CheckCommand(VISIT_ALICE.getNric()); assertTrue(checkFirstCommand.equals(checkFirstCommandCopy)); // different types -> returns false @@ -80,8 +81,8 @@ void equals() { @Test void testToString() { - CheckCommand checkCommand = new CheckCommand(ALICE.getNric()); - String expected = CheckCommand.class.getCanonicalName() + "{nric=" + ALICE.getNric() + "}"; + CheckCommand checkCommand = new CheckCommand(VISIT_ALICE.getNric()); + String expected = CheckCommand.class.getCanonicalName() + "{nric=" + VISIT_ALICE.getNric() + "}"; assertEquals(expected, checkCommand.toString()); }