change log level on record ingestion failures #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperez999
requested review from
edknv,
randerzander,
jdye64,
drobison00 and
ChrisJar
and removed request for
a team
edknv
approved these changes
Feb 18, 2025
drobison00
reviewed
Feb 19, 2025
| @@ -363,9 +363,9 @@ def _pull_text(element, enable_text: bool, enable_charts: bool, enable_tables: b | |||
| pg_num = element["metadata"]["content_metadata"]["page_number"] | |||
| doc_type = element["document_type"] | |||
| if not verify_emb: | |||
| logger.error(f"failed to find embedding for entity: {source_name} page: {pg_num} type: {doc_type}") | |||
| logger.info(f"failed to find embedding for entity: {source_name} page: {pg_num} type: {doc_type}") | |||
There was a problem hiding this comment.
Anything that get's logged to info would (should) have been logged by error. Is this trying to solve for missing error information?
There was a problem hiding this comment.
No this is so that we dont see the logs all the time. Currently in error they come up always. We got requests to make this less noisy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the log level for messages that inform the user that a given record failed ingestion because of missing data.
Checklist