Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Misleading comment in example 05_batched_gemm #1773

Open
lucifer1004 opened this issue Sep 4, 2024 · 2 comments
Open

[DOC] Misleading comment in example 05_batched_gemm #1773

lucifer1004 opened this issue Sep 4, 2024 · 2 comments

Comments

@lucifer1004
Copy link
Contributor

Report incorrect documentation

Location of incorrect documentation

// Arbitrary problem size
int const m = 520;
int const n = 219;
int const k = 129;
int const batch_count = 17;

Describe the problems or issues found in the documentation
The comment says "Arbitrary problem size", which is misleading since batch_count here cannot be modified due to the fixed permutation here:

std::vector<size_t> permutation = {14, 11, 3, 10, 1, 13, 9, 4, 6, 16, 8, 15, 7, 12, 0, 2, 5};

Steps taken to verify documentation is incorrect
Change batch_count to other values and the compiled program will not be able to pass checks.

Suggested fix for documentation
Change "Arbitrary problem size" to "Arbitrary matrix shape" and add a blank line between k and batch_count to show that batch_count is not arbitrary here.

Copy link

github-actions bot commented Oct 4, 2024

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

Copy link

github-actions bot commented Jan 2, 2025

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant