Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pin twine to 6.0.1 #493

Merged
merged 22 commits into from
Feb 3, 2025
Merged

ci: Pin twine to 6.0.1 #493

merged 22 commits into from
Feb 3, 2025

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jan 21, 2025

Description

Usage

# Add snippet demonstrating usage

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

@ko3n1g ko3n1g requested a review from sarahyurick January 21, 2025 21:33
Comment on lines 23 to 24
pull_request:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is extra whitespace somewhere here.

@ko3n1g ko3n1g force-pushed the ko3n1g/chore/add-license-file branch from eac21e2 to cd4f03e Compare January 21, 2025 21:47
Comment on lines 23 to 24
pull_request:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pull_request:
pull_request:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the pull_request event trigger only for debug purposes. I wouldn't recommend pushing to testpypi per commit, as (test)pypi has a max project size which is more likely to be saturated if we push per commit

ko3n1g added 13 commits February 1, 2025 23:11
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
@ko3n1g
Copy link
Collaborator Author

ko3n1g commented Feb 2, 2025

Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g changed the title chore: Add license file ci: Pin twine to 6.0.1 Feb 2, 2025
@praateekmahajan
Copy link
Collaborator

You might have a trailing whitespace in the yml file causing CI to fail, could you run pre-commit on that file?

Copy link
Collaborator

@sarahyurick sarahyurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ko3n1g ko3n1g merged commit dc45b37 into main Feb 3, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants