Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile should use the correct nvidia channel to install libcu* #423

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Dockerfile should use the correct nvidia channel to install libcu* #423

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea4647f
fc
praateekmahajan Dec 11, 2024
3a3d547
remove extra -c
praateekmahajan Dec 11, 2024
586701a
missing /
praateekmahajan Dec 11, 2024
a2ed49f
use env var?
praateekmahajan Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,16 @@ LABEL "nemo.library"=${IMAGE_LABEL}
WORKDIR /opt

# Install the minimal libcu* libraries needed by NeMo Curator
RUN conda create -y --name curator -c conda-forge -c nvidia \
ENV _CUDA_VER=${CUDA_VER}
RUN conda create -y --name curator -c nvidia/label/cuda-${_CUDA_VER} -c conda-forge \
python=3.10 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like gpuCI is currently throwing an error here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently build arg's can't be in RUN, so had to create env var, which is ugly

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh lol, interesting. LGTM!

cuda-cudart \
libcufft \
libcublas \
libcurand \
libcusparse \
libcusolver && \
libcusolver \
cuda-nvvm && \
source activate curator && \
pip install --upgrade pytest pip

Expand Down
Loading