Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_sdpa_loop_split errors out with dynamic shape #3817

Closed
Priya2698 opened this issue Feb 3, 2025 · 3 comments · Fixed by #3854
Closed

test_sdpa_loop_split errors out with dynamic shape #3817

Priya2698 opened this issue Feb 3, 2025 · 3 comments · Fixed by #3854
Assignees
Labels
bug Something isn't working dynamic shapes Multi-GPU

Comments

@Priya2698
Copy link
Collaborator

PR #3807 switches tests exercising DID loop split to use dynamic shapes. The sdpa_loop_split test case currently does not work with dynamic shapes indicating a potential bug there around DID loop split.

CC: @wujingyue

@Priya2698 Priya2698 added bug Something isn't working dynamic shapes Multi-GPU labels Feb 3, 2025
@Priya2698 Priya2698 self-assigned this Feb 3, 2025
@wujingyue
Copy link
Collaborator

FWIW, I added a repro to https://github.com/NVIDIA/Fuser/tree/bug3817

@Priya2698
Copy link
Collaborator Author

Priya2698 commented Feb 5, 2025

I print out some values in the expression evaluator and it seems the inferred values for the shapes are incorrect:

2: StructHandle<Tensor<float, 3, 4>>{data=0, logical_size=2 6 1024, logical_stride=3072 1024 1, alloc_size=1 2 3 1024, alloc_stride=3072 3072 1024 1}

The above is log_sumexp. This is not the case for all tensors.
I am not certain if this is due to the logic of DID loop split, could be that symbolic shapes are not correctly inferred for DID parallelized tvs. I need to debug further to verify the latter.

@wujingyue
Copy link
Collaborator

I vaguely remember @csarofeen found a bug with allocation of symbolic shapes when working on #3826. Could be related...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dynamic shapes Multi-GPU
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants