Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding issues and size reestrictions #10

Open
knzo25 opened this issue Apr 21, 2024 · 0 comments
Open

Encoding issues and size reestrictions #10

knzo25 opened this issue Apr 21, 2024 · 0 comments

Comments

@knzo25
Copy link

knzo25 commented Apr 21, 2024

First of all, thank your for this amazing project !

I was checking the code an examples of this package, but I seem to run on encoding issues and have not been able to replicate some of your results.

For example, running the example rosbag, I can get this image:

ros2 launch isaac_ros_h264_decoder isaac_ros_h264_decoder_rosbag.launch.py rosbag_path:=src/isaac_ros_compression/resources/rosbags/h264_compressed_sample.bag

example

However, when I try to encode my camera's data, or even the above image, the resulting image quality is quite bad.
I tried using all of the parameters, including the two default profiles and the custom one, but did not have luck in a correct encoding.

For example, If I use the previous image and your tests to encode/decode it again, this is the result:
(of course, I modified the image dimensions in the test files, but did not change the encoding profile)

colcon test --event-handlers console_cohesion+ --packages-select isaac_ros_h264_encoder
colcon test --event-handlers console_cohesion+ --packages-select isaac_ros_h264_decoder

uncompressed2

Do you happen to know what the reason behind this scenario is? 🙏
My development hardware is a RTX3060 and just in case I did try to convert video using nvenc and ffmpeg but did work as expected, so I am not sure how to proceed debugging this issue.

I was wondering whether a separate issue would be preferable, but is there any reason for the limitations stated here
https://nvidia-isaac-ros.github.io/repositories_and_packages/isaac_ros_compression/isaac_ros_h264_encoder/index.html#input-restrictions

I am working with 5MP cameras, so I am interested on what is the reason behind this limitation

Thank you very much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant