Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment 2021-1 #22

Open
13 of 18 tasks
gwbischof opened this issue Jan 8, 2021 · 3 comments
Open
13 of 18 tasks

Deployment 2021-1 #22

gwbischof opened this issue Jan 8, 2021 · 3 comments

Comments

@gwbischof
Copy link
Contributor

gwbischof commented Jan 8, 2021

Previsit

  • Make sure that the current latest environments are pushed to all the bl machines
  • Skim the IPython startup files in profile_collection
    • Check if it's safe to start bsui remotely (does it touch any hardware?) - use git grep .put or git grep caput
  • Check for outstanding PRs and issues on beamline repos
  • Check if beamline specific packages pushed to the BL machines
  • (Optional) Enable CI

Housekeeping

  • Add BL staff to the BL GitHub organization as owners
  • Work with BL staff to commit any un-committed changes to their profiles
  • Tag the profile as-found as 2019C3.x
  • Discuss with BL staff which conda envs they want to keep/delete and perform the cleanup
  • Check/update the beamline's inventory with the BL staff (in https://github.com/NSLS-II/playbooks/blob/master/production)

Test deployment

@gwbischof
Copy link
Contributor Author

During the testing phase of the deployment, we noticed that documents were not published to ZMQ as expected. We saw that it works correctly for older environments.

The cause of this was that this line fails in the newest environment, which prevents the remaining startup scripts from loading.
https://github.com/NSLS-II-PDF/profile_collection/blob/master/startup/94-load.py#L79

We are seeing this error when the previous line executes:
image

Which appears to be caused by this:
image

@danielballan
Copy link

A fix has been applied upstream in xpdacq and released in xpdacq 0.12.0. It needs to be verified at PDF.

The relevant commit is xpdAcq/xpdAcq@d0070ec. It removes use of pyFAI.gui.cli_calibration (which evidently imports PyQt5) and uses pyFAI.calibrant instead.

I propose to source-install xpdacq 0.12.0 to verify and then go through the process of making a new, fixed conda environment if it works.

@tacaswell
Copy link
Member

This is what the preload logic in bsui does, but I think the logic is too restrictive (only looking for 2020-2.0* in the name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants