Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7th seminar #5

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

7th seminar #5

wants to merge 3 commits into from

Conversation

SeoyoungOhMe
Copy link
Collaborator

@SeoyoungOhMe SeoyoungOhMe commented May 27, 2024

πŸ”₯Pull requests

⛳️ μž‘μ—…ν•œ 브랜치

πŸ‘· μž‘μ—…ν•œ λ‚΄μš©

  • 기쑴의 μ½”λ“œμ— SOLID νŒ¨ν„΄μ„ μ μš©ν–ˆμŠ΅λ‹ˆλ‹€.(기본과제)
  • 폴더링을 μ‹ κ²½μ¨μ„œ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
  • viewDidLoadμ—λŠ” ν•¨μˆ˜λ§Œ 듀어가도둝 μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
  • 전에 μ‹€νŒ¨ν–ˆλ˜ API 연결에 μ„±κ³΅ν–ˆμŠ΅λ‹ˆλ‹€.
  • 이슈λ₯Ό 파고 PR을 μͺΌκ°œμ„œ μ˜¬λ¦¬λŠ” 것을 μ‹œλ„ν•΄λ³΄μ•˜μŠ΅λ‹ˆλ‹€.

🚨 μ°Έκ³  사항

  • μˆ˜μ •λœ 폴더링은 λ‹€μŒκ³Ό κ°™μŠ΅λ‹ˆλ‹€.
.
β”œβ”€β”€ Week2_assignment
β”‚Β Β  β”œβ”€β”€ Application
β”‚Β Β  β”œβ”€β”€ Base.lproj
β”‚Β Β  β”œβ”€β”€ Global
β”‚Β Β  β”‚Β Β  β”œβ”€β”€ Extensions
β”‚Β Β  β”‚Β Β  β”œβ”€β”€ Resources
β”‚Β Β  β”‚Β Β  └── Settings
β”‚Β Β  β”‚Β Β      β”œβ”€β”€ Config.swift
β”‚Β Β  β”‚Β Β      └── Info.plist
β”‚Β Β  β”œβ”€β”€ Network
β”‚Β Β  β”‚Β Β  β”œβ”€β”€ Base
β”‚Β Β  β”‚Β Β  β”‚Β Β  β”œβ”€β”€ BaseService.swift
β”‚Β Β  β”‚Β Β  β”‚Β Β  β”œβ”€β”€ BaseTargetType.swift
β”‚Β Β  β”‚Β Β  β”‚Β Β  β”œβ”€β”€ MoyaLoggingPlugin.swift
β”‚Β Β  β”‚Β Β  β”‚Β Β  β”œβ”€β”€ NetworkResult.swift
β”‚Β Β  β”‚Β Β  β”‚Β Β  └── NetworkService.swift
β”‚Β Β  β”‚Β Β  └── BoxOffice
β”‚Β Β  β”‚Β Β      β”œβ”€β”€ BoxOfficeService.swift
β”‚Β Β  β”‚Β Β      β”œβ”€β”€ BoxOfficeTargetType.swift
β”‚Β Β  β”‚Β Β      └── DTO
β”‚Β Β  β”‚Β Β          └── GetBoxOfficeResponse.swift
β”‚Β Β  └── Presentation
β”‚Β Β      β”œβ”€β”€ ContentCollection
β”‚Β Β      β”‚Β Β  β”œβ”€β”€ Cell
β”‚Β Β      β”‚Β Β  β”‚Β Β  β”œβ”€β”€ BaseballCollectionViewCell.swift
β”‚Β Β      β”‚Β Β  β”‚Β Β  β”œβ”€β”€ HeaderCollectionView.swift
β”‚Β Β      β”‚Β Β  β”‚Β Β  β”œβ”€β”€ LiveCollectionViewCell.swift
β”‚Β Β      β”‚Β Β  β”‚Β Β  β”œβ”€β”€ PosterCollectionViewCell.swift
β”‚Β Β      β”‚Β Β  β”‚Β Β  └── TabControllCollectionViewCell.swift
β”‚Β Β      β”‚Β Β  β”œβ”€β”€ ContentCollectionViewCell.swift
β”‚Β Β      β”‚Β Β  β”œβ”€β”€ ContentViewController.swift
β”‚Β Β      β”‚Β Β  β”œβ”€β”€ Model
β”‚Β Β      β”‚Β Β  β”‚Β Β  β”œβ”€β”€ BaseballSlogan.swift
β”‚Β Β      β”‚Β Β  β”‚Β Β  β”œβ”€β”€ LiveProgramModel.swift
β”‚Β Β      β”‚Β Β  β”‚Β Β  └── PosterModel.swift
β”‚Β Β      β”‚Β Β  └── ViewController
β”‚Β Β      β”‚Β Β      β”œβ”€β”€ MainViewController.swift
β”‚Β Β      β”‚Β Β      └── TabBarController.swift
β”‚Β Β      └── Welcome
β”‚Β Β          └── ViewController
β”‚Β Β              β”œβ”€β”€ ViewController.swift
β”‚Β Β              └── WelcomeViewController.swift

πŸ“Έ μŠ€ν¬λ¦°μƒ·

κΈ°λŠ₯ μŠ€ν¬λ¦°μƒ·
둜그인 뷰
메인 λ·°

πŸ“Ÿ κ΄€λ ¨ 이슈

@SeoyoungOhMe SeoyoungOhMe self-assigned this May 27, 2024
@SeoyoungOhMe SeoyoungOhMe marked this pull request as ready for review May 27, 2024 15:39
@SeoyoungOhMe SeoyoungOhMe changed the base branch from main to develop May 28, 2024 02:58
Copy link

@kim-seonwoo kim-seonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μƒλ‹Ήνžˆ λ§Žμ€ 변경이 λ³΄μ΄λ„€μš”..
정말.. μˆ˜κ³ λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€ !! πŸ™‡πŸ‘

var task: Task {
switch self {
case let .fetchBoxOfficeData(date):
return .requestParameters(parameters: ["key": "b4ddbf38f567f468512099872d9cc672", "targetDt": date], encoding: URLEncoding.queryString)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key값도 Configμ—μ„œ base url μˆ¨κΈ°μ‹  λ°©μ‹μ²˜λŸΌ μ²˜λ¦¬ν•˜μ‹œλ©΄ μ•ˆμ „ν•˜λ‹΅λ‹ˆλ‹€!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 이것떄문에 κΏ€λ°€ν•œλ²ˆ λ§žμ•˜μŠ΅λ‹ˆλ‹€ μ„ μš°κ°€ λ§ν•œλŒ€λ‘œ Configμ—μ„œ base url 숨긴 λ°©λ²•μ²˜λŸΌ Privacy둜 κ΄€λ¦¬ν•˜λŠ”κ²ƒμ΄ μ’‹μŠ΅λ‹ˆλ‹€. μ•„λ‹ˆ κ·Έλ ‡κ²Œ ν•΄μ•Όν•©λ‹ˆλ‹€. (νŠΉνžˆλ‚˜ Gitλ ˆν¬κ°€ Public μƒνƒœλΌλ©΄.)
μ™œλƒν•˜λ©΄ μ΄λ ‡κ²Œ μ˜€ν”ˆλœ κΉƒ λ ˆν¬μ— 개인 ν‚€λ‚˜ μ„œλ²„ url이 μ˜€ν”ˆλ˜μ–΄μžˆλŠ” μƒνƒœλΌλ©΄ μ΄λŸ°κ²ƒλ§Œ μ „λ¬Έμ μœΌλ‘œ ν¬λ‘€λ§ν•˜λŠ” μ‚¬λžŒλ“€μ΄ ν•΄λ‹Ή ν‚€λ₯Ό 보고 μ„œμ˜λ‹˜ μ„œλ²„λ‚˜ 킀에 μ ‘κ·Όν•΄μ„œ λ©‹λŒ€λ‘œ μ‚¬μš©ν• μˆ˜λ„ μžˆλŠ” μœ„ν—˜ν•œ 상황이 μžˆμ„μˆ˜ μžˆμŠ΅λ‹ˆλ‹€.
κ°œμΈμ •λ³΄ 보호λ₯Ό μœ„ν•΄ privacyλ₯Ό μƒν™œν™” ν•΄λ΄μš”!!

(μ–΄λ €μš΄ λ‚΄μš©μ€ μ•„λ‹ˆκ³  privacy Info.plist , git ignore <- 이 ν‚€μ›Œλ“œλ‘œ κ²€μƒ‰ν•˜μ‹œλ©΄ μ΄ν•΄λ˜μ‹€κ±°μ—μš”)

Comment on lines +109 to +116
view.addSubview(titleLabel)
view.addSubview(idTextField)
view.addSubview(passwordTextField)
view.addSubview(loginButton)
view.addSubview(idFindButton)
view.addSubview(passwordFindButton)
view.addSubview(accountQuestionLabel)
view.addSubview(signUpButton)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μžλ£Œμ‹€μ— μžˆλŠ” addSubviews μ΅μŠ€ν…μ…˜ 써봐도 쒋을것 κ°™μ•„μš”!!

Comment on lines +220 to +225
if let image = UIImage(named: "x-circle") {
let imageSize = image.size
print("Image Size: \(imageSize)")
} else {
print("Image not found or couldn't be loaded.")
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

였옹 이뢀뢄은 μ–΄λ–€ 이유둜 μ“°μ‹œκ²Œ λ˜μ…¨λ‚˜μš”~?

Copy link

@hooni0918 hooni0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„λ¦„λ‹€μš΄ μ½”λ“œ μž˜λ³΄κ³ κ°‘λ‹ˆλ‹€. μ˜€λŠ˜λ„ ν–‰λ³΅ν•œ ν•˜λ£¨ λ˜μ„Έμš” :)


extension UITextField {

/// ν…μŠ€νŠΈν•„λ“œμ˜ μ™Όμͺ½κ³Ό 였λ₯Έμͺ½μ— νŒ¨λ”©μ„ μΆ”κ°€ν•˜λŠ” ν•¨μˆ˜

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν•˜λ‚˜μ”© μ•Œμ•„κ°€λ €λŠ” λͺ¨μŠ΅ 정말 μ’‹μŠ΅λ‹ˆλ‹€!!!

var task: Task {
switch self {
case let .fetchBoxOfficeData(date):
return .requestParameters(parameters: ["key": "b4ddbf38f567f468512099872d9cc672", "targetDt": date], encoding: URLEncoding.queryString)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 이것떄문에 κΏ€λ°€ν•œλ²ˆ λ§žμ•˜μŠ΅λ‹ˆλ‹€ μ„ μš°κ°€ λ§ν•œλŒ€λ‘œ Configμ—μ„œ base url 숨긴 λ°©λ²•μ²˜λŸΌ Privacy둜 κ΄€λ¦¬ν•˜λŠ”κ²ƒμ΄ μ’‹μŠ΅λ‹ˆλ‹€. μ•„λ‹ˆ κ·Έλ ‡κ²Œ ν•΄μ•Όν•©λ‹ˆλ‹€. (νŠΉνžˆλ‚˜ Gitλ ˆν¬κ°€ Public μƒνƒœλΌλ©΄.)
μ™œλƒν•˜λ©΄ μ΄λ ‡κ²Œ μ˜€ν”ˆλœ κΉƒ λ ˆν¬μ— 개인 ν‚€λ‚˜ μ„œλ²„ url이 μ˜€ν”ˆλ˜μ–΄μžˆλŠ” μƒνƒœλΌλ©΄ μ΄λŸ°κ²ƒλ§Œ μ „λ¬Έμ μœΌλ‘œ ν¬λ‘€λ§ν•˜λŠ” μ‚¬λžŒλ“€μ΄ ν•΄λ‹Ή ν‚€λ₯Ό 보고 μ„œμ˜λ‹˜ μ„œλ²„λ‚˜ 킀에 μ ‘κ·Όν•΄μ„œ λ©‹λŒ€λ‘œ μ‚¬μš©ν• μˆ˜λ„ μžˆλŠ” μœ„ν—˜ν•œ 상황이 μžˆμ„μˆ˜ μžˆμŠ΅λ‹ˆλ‹€.
κ°œμΈμ •λ³΄ 보호λ₯Ό μœ„ν•΄ privacyλ₯Ό μƒν™œν™” ν•΄λ΄μš”!!

(μ–΄λ €μš΄ λ‚΄μš©μ€ μ•„λ‹ˆκ³  privacy Info.plist , git ignore <- 이 ν‚€μ›Œλ“œλ‘œ κ²€μƒ‰ν•˜μ‹œλ©΄ μ΄ν•΄λ˜μ‹€κ±°μ—μš”)

private func setStyle() {
self.navigationController?.navigationBar.isHidden = true

mainPoster.do {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ™€μš° .do λ₯Ό μ‚¬μš©ν•˜λ‹ˆ 훨씬 가독성이 μ’‹μ•„μ‘‹λ„€μš”! doλ₯Ό μ΄λ ‡κ²Œ 잘 μ‚¬μš©ν•˜μ‹œλ‹€λ‹ˆ 정말 λ©‹μ Έμš”!!

Comment on lines +162 to +193
// //ν…Œμ΄λΈ” 뷰에 μ…€ 등둝 1.μ–΄λ–€ μ…€ 등둝할지 2.μ‹λ³„μž
// private func register() {
// contentTableView.register(
// ContentTableViewCell.self,
// forCellReuseIdentifier: ContentTableViewCell.identifier
// )
// }
// private func setDelegate() {
// contentTableView.delegate = self
// contentTableView.dataSource = self
// }

}

//extension MainViewController: UITableViewDelegate {
// func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
// return tableView.frame.width // ν…Œμ΄λΈ” 뷰의 λ„ˆλΉ„λ₯Ό μ…€μ˜ λ†’μ΄λ‘œ μ‚¬μš©ν•˜μ—¬ κ°€λ‘œ μŠ€ν¬λ‘€μ„ μœ„ν•œ 높이 쑰절
// }
//}

//extension MainViewController: UITableViewDataSource {
// func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
// return 5
// }
//
// func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
// guard let cell = tableView.dequeueReusableCell(withIdentifier: ContentTableViewCell.identifier, for: indexPath) as? ContentTableViewCell else { return UITableViewCell() }
// cell.dataBind(contentList[indexPath.row])
// return cell
// }
//}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ§€μš°κΈ°!

Comment on lines +250 to +257
protocol LoginPresenterProtocol {
func didTapLoginButton(id: String?, password: String?)
func didChangeTextField(text: String?, for textField: UITextField)
}

// MARK: - LoginPresenter
class LoginPresenter: LoginPresenterProtocol {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μš”λΆ€λΆ„λ„ μƒˆλ‘­κ²Œ λΆ„λ¦¬ν•΄λ³΄λŠ”κ²ƒ μΆ”μ²œλ“œλ €μš” 같은 νŒŒμΌλ‚΄λΆ€λ³΄λ‹€ μ΄λΆ€λΆ„λ§Œ λ„λ €λ‚΄μ„œ μƒˆλ‘œμš΄ .swift파일둜 λ§Œλ“€μ–΄λ„ μ’‹μ„κ²ƒκ°™μŠ΅λ‹ˆλ‹€ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] λ¦¬νŽ™ν† λ§
3 participants