Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkmf not included in installation #229

Open
uramirez8707 opened this issue Oct 29, 2024 · 7 comments · Fixed by #245
Open

mkmf not included in installation #229

uramirez8707 opened this issue Oct 29, 2024 · 7 comments · Fixed by #245

Comments

@uramirez8707
Copy link
Contributor

Describe the bug
mkmf is not included in the installation, fre make will fail when trying to use it

To Reproduce
Install fre-cli and attempt to run fre make, it will fail because it cannot find mkmf in the path

Expected behavior
fre-cli should include mkmf (i.e all of its dependencies)

Additional context
You can work around this by cloning mkmf and adding it to your path, or loading fre/bronx-22 if on gaea.

@singhd789
Copy link
Collaborator

@uramirez8707 Just fyi, the module for fre/bronx should already be included in the platforms.yaml, as shown here (this needs to be updated) for gaea:

modules: [ !join [*INTEL, "/2022.2.1"],"fre/bronx-20",cray-hdf5/1.12.2.3, cray-netcdf/4.9.0.3]

@uramirez8707
Copy link
Contributor Author

This is still an issue. mkmf needs to be added to the PATH otherwise fre won't work.

@ceblanton
Copy link
Collaborator

If mkmf were conda-installable it could be included as a proper dependency. This would be the most direct solution IMO.

@singhd789
Copy link
Collaborator

Yes, if someone could make it a conda package, that might be easier

@singhd789 singhd789 reopened this Dec 18, 2024
@ilaflott
Copy link
Member

export PATH=$PATH:$PWD ?

@singhd789
Copy link
Collaborator

singhd789 commented Dec 18, 2024

@ilaflott
Copy link
Member

that line does add it, yes. but that's only for github's CI/CD. When one does a conda install noaa-gfdl::fre-cli, mkmf should be stuck in $PATH as part of the build section of meta.yaml.

Really, it'd be best to add it to $PATH as part of the pip install routine, but that not being there will only affect a dev like me who knows they can band-aid that easily with their own export PATH=blahblah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants