-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how to build land_model_mod.mod? #14
Comments
@edwardhartnett what compiler are you using? What version of hdf5 are you using? Is the build error a problem with hdf5? Does it fail in tiling_input.F90? |
I can build (or at least try to build) FMScoupler with either GNU or Intel Fortran. I am trying Intel Fortran at the moment. This is using a new, autotools-based build system. The error I get is:
|
@edwardhartnett you need to build fms, land_lad2, mom6, ice_sis, atmos_phys, and atmos_dyn before you can build coupler. FMS_coupler depends on all of those components. If land_model_mod.mod is missing, then it's likely that it did not build. If the problem with building the land model is in tiling_input.F90, it is likely an hdf5 issue. I can merge #12 to possibly fix the problem. |
@edwardhartnett I merged #12. This is hopefully resolve issues with compiling the land model with "newer" version of hdf5. Please try to recompile the land and see if it works now. |
OK, thanks for the info! I will keep trying... |
OK, I've updated the code. Now I see a failure like this:
|
@edwardhartnett hid_t and size_t are both defined in hdf5. I cloned and compiled the AM4 code with hdf5/1.10.4 and hdf5/1.8.16, and I didn't have this problem. It looks like you have the hdf5 include path, so I'm not sure why you are getting this problem. Did you pull the latest changes to the master branch after I merged in #12? |
@thomas-robinson I am having this same issue on lscsky50-d with Inetl19.
Note, there is no hillslope_hydrology_mod in this code base. |
hillslope_hydrology_mod is in the repo, but something removed it from src/!!!
I did a git checkout land_lad2/soil/hillslope_hydrology.F90 and the compile went OK! |
Would it be possible to include some improved documentation for compiling AM4? The Makefile and templates are a great start, but they seem to have features specific to the system on which they were built. It seems to be implied that |
@markyoder I have sort of an unsatisfying answer for you. TLDR: open a new issue and request what you want specifically. The Makefiles were indeed generated using list_paths and mkmf. list_paths lists the paths of the files in folder and any subfolders. mkmf resolves the dependancies of the modules, and generates a Makefile based on those dependancies. They should work on any system. The Makefiles also reference a template included in the templates directory. The template is specific for the compiler. The intel.mk file should work, and gnu.mk file may work. cmake and autotools are great tools for compiling, and are being used or are in the process of being added to some of the components of this model. As you can tell from this issue, compiling the code isn't as straightforward as it could be, so there are some snags to adding a more automated build system. The intent of this repository was to provide a mechanism to reproduce the scientific results of the AM4 papers. With that said, if you have a feature or documentation request, it would be great if you could open a separate issue on the request, and then I can address it more directly and hopefully spend a little bit of time to add it. |
Thanks Thomas. I guess it would be nice if the documentation just said, "modify the templates and use these makefiles." There are other related codes where |
The FMScoupler project has a dependency on missing land_model_mod.mod. See NOAA-GFDL/FMScoupler#15.
So I am trying to build land_model_mod.mod so that I can get the autotools build for FMScoupler working.
However, when I build AM4 according to your home rolled build system (a.k.a. your "workflow") it does not build land_model_mod.mod.
How do I get AM4, using your legacy build system, to build land_model_mod.mod?
Thanks!
The text was updated successfully, but these errors were encountered: