Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sorc/gsi_enkf.fd hash #3027

Closed
1 task
RussTreadon-NOAA opened this issue Oct 22, 2024 · 6 comments · Fixed by #3207
Closed
1 task

Update sorc/gsi_enkf.fd hash #3027

RussTreadon-NOAA opened this issue Oct 22, 2024 · 6 comments · Fixed by #3207
Assignees
Labels
feature New feature or request

Comments

@RussTreadon-NOAA
Copy link
Contributor

What new functionality do you need?

g-w develop currently points at gsi_enkf.fd @ 9f44c87. This is an older hash of NOAA-EMC/GSI develop.

Missing in the current g-w sorc/gsi_enkf.fd hash is GSI PR #790. This PR corrects a bug in IASI code so that gsi.x can successfully run to completion in debug mode. NCO pre-implementation testing requires executables to successfully run in debug mode.

This issue is opened to note the need to update and, as appropriate, keep updating the sorc/gsi_enkf.fd hash for GFS v17 (and possibly GFS v16.4)

What are the requirements for the new functionality?

Keep sorc/gsi_enkf.fd up to date with the NOAA-EMC/GSI hash required by GFS v16.4 and/or GFS v17.

Acceptance Criteria

  • gsi.x and enkf.x successfully run to completion after updating sorc/gsi_enkf.fd hash

Suggest a solution (optional)

No response

@RussTreadon-NOAA
Copy link
Contributor Author

@CatherineThomas-NOAA and @ADCollard : Two questions

  1. When should we update the gsi_enkf.fd hash in g-w?
  2. To which GSI hash do we update gsi_enkf.fd?

@CatherineThomas-NOAA
Copy link
Contributor

@RussTreadon-NOAA:
For v17, a g-w PR is being prepared for the soil DA that will update the GSI hash. I'm not aware of any reason not to update to the head of develop, are you?

@RussTreadon-NOAA
Copy link
Contributor Author

@CatherineThomas-NOAA , my preference is to keep DA g-w hashes as close as possible (and practical) to the head of their respective develop. Updating sorc/gsi_enkf.fd to 27c03e8 works for me.

I see some GSI issues (e.g., #783 , #809) which we probably want in g-w. These issues do not, at present, have corresponding PRs.

@RussTreadon-NOAA
Copy link
Contributor Author

Work for this issue will be done in RussTreadon-NOAA:feature/update_gsi_enkf

RussTreadon-NOAA added a commit to RussTreadon-NOAA/global-workflow that referenced this issue Jan 6, 2025
@RussTreadon-NOAA
Copy link
Contributor Author

g-w develop versions/fix.ver currently sets gsi_ver=20240208. In constrast, the modulefiles in the updated gsi_enkf.fd reference gsi/20241022. gsi_ver should be updated to be consistent with the newer gsi_enkf.fd hash.

RussTreadon-NOAA added a commit to RussTreadon-NOAA/global-workflow that referenced this issue Jan 6, 2025
@CatherineThomas-NOAA
Copy link
Contributor

gsi_ver should be updated to be consistent with the newer gsi_enkf.fd hash.

Thanks @RussTreadon-NOAA. @ClaraDraper-NOAA: see Russ's comment above.

aerorahul pushed a commit that referenced this issue Jan 8, 2025
This PR updates the `sorc/gsi_enkf.fd` hash. `gsi_ver` is updated to be
consistent with the `gsi_enkf.fd` hash.

Resolves #3027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants