Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requested changes in support of SRW App #150

Closed
edwardhartnett opened this issue Oct 20, 2020 · 3 comments · Fixed by #148
Closed

Requested changes in support of SRW App #150

edwardhartnett opened this issue Oct 20, 2020 · 3 comments · Fixed by #148
Assignees
Labels
enhancement New feature or request

Comments

@edwardhartnett
Copy link
Contributor

The SRW App wants an easier way to set environment variables or load modules than loading individual NCEPLIBS modules etc. This was discussed at length in last week's SRW App build team meeting. It was decided to augment the NCEPLIBS with an umbrella modulefile (for systems that use modules) and shell scripts (bash and tcsh; for users on commodity systems without the module environment). This is similar to what was done for the MRW App release.

The approach taken here:

use the existing logic to deploy modulefiles and extend it with an umbrella module and two shell scripts
for simplicity, DEPLOY is by default ON and running make deploy will always overwrite existing files
also add CC, CXX, FC to the umbrella modulefile and the shell scripts; if this is not to be included, we can revert adding CXX to the cmake project languages - should it be removed?
extend lua2tcl.py so that the umbrella modulefile can also be converted
not included yet: scan currently loaded modules and add those (either as module load or prereq) to the umbrella module file - should it be included?
not included yet: search for known dependencies for the app to build (NetCDF, Jasper, ESMF, ...) in the umbrella CMakeLists.txt and add to the umbrella modulefile and shell scripts - should it be included?

@climbfuji
Copy link
Collaborator

The SRW App wants an easier way to set environment variables or load modules than loading individual NCEPLIBS modules etc. This was discussed at length in last week's SRW App build team meeting. It was decided to augment the NCEPLIBS with an umbrella modulefile (for systems that use modules) and shell scripts (bash and tcsh; for users on commodity systems without the module environment). This is similar to what was done for the MRW App release.

The approach taken here:

use the existing logic to deploy modulefiles and extend it with an umbrella module and two shell scripts
for simplicity, DEPLOY is by default ON and running make deploy will always overwrite existing files
also add CC, CXX, FC to the umbrella modulefile and the shell scripts; if this is not to be included, we can revert adding CXX to the cmake project languages - should it be removed?
extend lua2tcl.py so that the umbrella modulefile can also be converted
not included yet: scan currently loaded modules and add those (either as module load or prereq) to the umbrella module file - should it be included?
not included yet: search for known dependencies for the app to build (NetCDF, Jasper, ESMF, ...) in the umbrella CMakeLists.txt and add to the umbrella modulefile and shell scripts - should it be included?

Thanks, @edwardhartnett I could have (and should have) done that myself. Will do better next time,

@edwardhartnett
Copy link
Contributor Author

Has this work been completed? Should this issue be closed?

@edwardhartnett edwardhartnett added the enhancement New feature or request label Dec 4, 2020
@climbfuji
Copy link
Collaborator

This work was completed in release/public-v2. It's not in develop and per @aerorahul it won't go there. In release/public-v2, we also converted all lua modulefiles to tcl modulefiles, because at that time we didn't have lua support on gaea (which we now do).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants