Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So very many more tests needed #37

Closed
edwardhartnett opened this issue Oct 6, 2020 · 4 comments
Closed

So very many more tests needed #37

edwardhartnett opened this issue Oct 6, 2020 · 4 comments

Comments

@edwardhartnett
Copy link
Contributor

We seem to have 7 lines of test code. ;-)

Well that's not enough, is it?

@edwardhartnett
Copy link
Contributor Author

OK, no more bumping this to the next release.

@kgerheiser
Copy link
Contributor

kgerheiser commented Apr 4, 2022

This is going to be a huge task given the quality of the code.

Thought this was #78 and meant to put that comment in there, but it still applies.

@edwardhartnett
Copy link
Contributor Author

I keep hearing that GRIB1 will go away, but I'm starting to wonder if it will. Right now it's "only" used for the aviation forecast.

Well, that seems like a pretty important application. I'm no atmospheric scientist, but I'm pretty sure that weather forecasts are pretty important to the tens of thousands of people in the air every day.

Let's start by adding tests to all code touched in any PR. That will start to build up the tests.

Warnings should not be attempted until we have more testing. It's too easy to accidentally break code.

Anyway, here we are, doing releases of this super-important code without even a test to bless ourselves with.

@edwardhartnett
Copy link
Contributor Author

OK, some tests have been added, but we are still at only 2% test coverage. I've added a bunch of specific test issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants