Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty include_* directories installed #48

Closed
opoplawski opened this issue Oct 17, 2020 · 3 comments · Fixed by #82
Closed

Empty include_* directories installed #48

opoplawski opened this issue Oct 17, 2020 · 3 comments · Fixed by #82
Assignees
@edwardhartnett
Labels
build Building software can be complicated

Comments

@opoplawski
Copy link
Contributor

Perhaps I should just wait until NOAA-EMC/NCEPLIBS-ip#226 is resolved, but I'm looking at packaging this for Fedora. At the moment it install the following empty directories:

/usr/include_4
/usr/include_8
/usr/include_d

These directories are not allowed in Fedora. If I remove them then the cmake modules cannot be imported because their interface directories have be removed. One solution might be to have the option to install into /usr/include/splib/include_*. Thoughts?
@edwardhartnett
Copy link
Contributor

We hope to move on NOAA-EMC/NCEPLIBS-ip#226 soon, which will resolve this.

Of course, these directory names must go, and we will install in an "include" directory like everyone else in the world does.

@edwardhartnett
Copy link
Contributor

Howdy @opoplawski !

I am about to do a release of sp and am looking at issues. I see that there are no include files in sp. So how about I just remove these directories from the CMake build as you suggest?

@edwardhartnett edwardhartnett self-assigned this Jan 6, 2023
@edwardhartnett edwardhartnett added the build Building software can be complicated label Jan 6, 2023
@opoplawski
Copy link
Contributor Author

That would be great, thanks!

@edwardhartnett edwardhartnett mentioned this issue Jan 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edwardhartnett edwardhartnett

Labels
build Building software can be complicated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed unused include_* directories in install NOAA-EMC/NCEPLIBS-sp
2 participants
@opoplawski @edwardhartnett