bugfix/global_det_units #581
Conversation
There was a problem hiding this comment.
I have compared this PR to the previous unit fix PR that was merged into develop. This PR doesn't include the changes to ush/global_det/global_det_atmos_long_term_util.py, which is expected because the long-term plot scripts aren't included in prod EVS. Everything else looks consistent. I approve this PR for merge after it is tested. Thanks!
|
@malloryprow I'm sure you won't see these until tomorrow. It's late in the day (after 3 pm) so I'm guessing we wouldn't have to adjust VDATE_END, or anything like that. Just wanted to get this started if you return to work tomorrow. |
|
The .o files will be located here: /lfs/h2/emc/vpppg/noscrub/perry.shafran/pr581test/EVS/dev/drivers/scripts/plots/global_det And the plot tarballs will be here: /lfs/h2/emc/ptmp/perry.shafran/evs/v1.0/plots/global_det, atmos.20241007 and headline.20241007 |
|
Going to get this sent up to EMCRZDM to the test website to review this morning. |
|
Thank you! Don't forget to sync fork while you're doing that. |
|
This one should be good since it isn't off develop. |
|
oh wait, never mind, this isn't a develop PR, you don't need to sync. |
|
Ah, realizing that since the plots are a few days old I can't compare to the ops plots now. I want to make sure we get this right. Can we re-run for VDATE_END=20241008? |
|
Yup, will do. |
|
@malloryprow Most jobs are finished, with just two more jobs still ongoing. You can start checking out some of the tar files. |
|
✅ headline is good. atmos will take a little longer to untar everything and then review. Will update when that is done. |
|
✅ atmos is good. |
|
Excellent! Let me then do the code check and then merge. |
Note to developers: You must use this PR template!
Description of Changes
This contains the fixes in #526 to a release branch for operations. Closes #573.
Developer Questions and Checklist
${USER}where necessary throughout the code.HOMEevsare removed from the code.dev/drivers/scriptsordev/modulefileshave been made in the correspondingecf/scriptsandecf/defs/evs-nco.def?Testing Instructions
Set-up
ln -sf /lfs/h2/emc/vpppg/noscrub/emc.vpppg/verification/EVS_fix fixevs_verin versions/run.ver.✅ global_det atmos plots
cd dev/drivers/scripts/plots/global_detjevs_global_det_atmos_grid2grid_means_plots_31days.sh,jevs_global_det_atmos_grid2grid_precip_plots_31days.sh,jevs_global_det_atmos_grid2grid_pres_levs_plots_31days.sh,jevs_global_det_atmos_grid2grid_sea_ice_plots_31days.sh,jevs_global_det_atmos_grid2grid_snow_plots_31days.sh,jevs_global_det_atmos_grid2grid_sst_plots_31days.sh,jevs_global_det_atmos_grid2obs_pres_levs_plots_31days.sh,jevs_global_det_atmos_grid2obs_ptype_plots_31days.sh,jevs_global_det_atmos_grid2obs_sfc_plots_31days.sh, andjevs_global_det_atmos_headline_plots.sh.