-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/global_det_mpmd #610
feature/global_det_mpmd #610
Conversation
OK, on to plots. I will be working on things in the order they are listed in the instructions. |
The GFS wave plots are finished. The .o files are here: /lfs/h2/emc/vpppg/noscrub/perry.shafran/pr610test/EVS/dev/drivers/scripts/plots/global_det |
global_det wave plots looks good as well! Can we wait until 1845Z to test the global_det atmos stats? I reran the prep step this morning for the dates that didn't complete due to stmp filling up. The stats that ran yesterday in the emc.vpppg parallel wouldn't have data for those missing files. If we wait until the jobs run later today, both will be running using the same prep data and make it easier to compare the final stats files. |
Yes, we can wait. I think that will be around 2:45 pm, and that means that most jobs might end after your workday ends. I think some of the quick ones will finish before that. |
@malloryprow I think I miscalculated when 1845Z was, darn it. I'll set off all the atmos stats jobs now. |
Sounds good! I will review them tomorrow morning! |
Good with the first round of the global_det atmos stats. We can do the WMO stats next. Both daily and monthly. We can run the daily with VDATE=20241201 and the monthly with VDATE=20241130. |
@malloryprow Thank you for checking! On to the WMO stats. |
@malloryprow The wmo stats jobs are complete. .o files: /lfs/h2/emc/vpppg/noscrub/perry.shafran/pr610test/EVS/dev/drivers/scripts/stats/global_det |
The WMO stats look good for the daily! Could we run the monthly with VDATE=20241031? It looks like the output for 20231130 in the parallel is messed up from stmp filling up. |
Actually just caught something in the working directories using /lfs/h1/ops/prod/com/gfs/v16.3/gdas.YYYYmmdd/HH/atmos/gdas.tHHz.cnvstat. The file permissions need to be set to rstprod. I'll need to make a change for that. |
@malloryprow OK, let me know when you want me to run the monthly WMO for October. Does this file permission thing you are talking about refer to the daily or the monthly? |
It is the daily so both the WMO monthly and daily will need to be rerun
|
Both jobs are underway. |
@malloryprow Both the wmo jobs are complete if you want to check. The locations are the same as listed above. |
Re-running the daily wmo stats job as I had forgotten to pull in changes. Mallory says that the monthly wmo stats look good. |
I can comment on PRs again. Posting what I sent in an email. For the daily WMO job, it doesn't look like the changes were pulled in. /lfs/h2/emc/vpppg/noscrub/perry.shafran/pr610test/EVS/ush/global_det/global_det_atmos_stats_wmo_reformat_cnvstat.py doesn't have the changes. Can you pull the changes in and run again? No need to set VDATE or can do |
@malloryprow Running the daily job for 20241201. I did all the rm's before I submitted. |
WMO daily job is good! We can move on to plots. Please run with |
@malloryprow All plots jobs are underway. |
Everything is good for plots! |
OK cool! I'll do a code check and then approve if all is good. @AliciaBentley-NOAA You should check and approve when ready as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code works as expected. Approved for merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the changes made in this PR and found that they are consistent with the changes required to address the MPMD bugzilla. I like the introduction of data/
in the various paths and the ${job_work_dir}
variable. I approve this PR to be merged.
Excellent! Ready to merge! |
Note to developers: You must use this PR template!
Description of Changes
This includes development to address NCO Bugzilla 1547 for global_det. Closes #553.
Developer Questions and Checklist
${USER}
where necessary throughout the code.HOMEevs
are removed from the code.dev/drivers/scripts
ordev/modulefiles
have been made in the correspondingecf/scripts
andecf/defs/evs-nco.def
?Testing Instructions
Set-up
ln -sf /lfs/h2/emc/vpppg/noscrub/emc.vpppg/verification/EVS_fix fix
✅ global_det stats - wave
cd dev/drivers/scripts/stats/global_det
jevs_global_det_gfs_wave_grid2obs_stats.sh
✅ global_det plots - wave
cd dev/drivers/scripts/plots/global_det
jevs_global_det_wave_grid2obs_plots_last31days.sh
,jevs_global_det_wave_grid2obs_plots_last90days.sh
✅ global_det stats - atmos
cd dev/drivers/scripts/stats/global_det
jevs_global_det_cfs_atmos_grid2grid_stats.sh
,jevs_global_det_cfs_atmos_grid2obs_stats.sh
,jevs_global_det_cmc_atmos_grid2grid_stats.sh
,jevs_global_det_cmc_atmos_grid2obs_stats.sh
,jevs_global_det_cmc_regional_atmos_grid2grid_stats.sh
,jevs_global_det_dwd_atmos_grid2grid_stats.sh
,jevs_global_det_ecmwf_atmos_grid2grid_stats.sh
,jevs_global_det_ecmwf_atmos_grid2obs_stats.sh
,jevs_global_det_fnmoc_atmos_grid2grid_stats.sh
,jevs_global_det_fnmoc_atmos_grid2obs_stats.sh
,jevs_global_det_gfs_atmos_grid2grid_stats.sh
,jevs_global_det_gfs_atmos_grid2obs_stats.sh
,jevs_global_det_imd_atmos_grid2grid_stats.sh
,jevs_global_det_imd_atmos_grid2obs_stats.sh
,jevs_global_det_jma_atmos_grid2grid_stats.sh
,jevs_global_det_jma_atmos_grid2obs_stats.sh
,jevs_global_det_metfra_atmos_grid2grid_stats.sh
,jevs_global_det_ukmet_atmos_grid2grid_stats.sh
,jevs_global_det_ukmet_atmos_grid2obs_stats.sh
jevs_global_det_gfs_atmos_wmo_daily_stats.sh
jevs_global_det_gfs_atmos_wmo_monthly_stats.sh
✅ global_det stats - atmos
cd dev/drivers/scripts/plots/global_det
jevs_global_det_atmos_grid2grid_means_plots_last31days.sh
,jevs_global_det_atmos_grid2grid_means_plots_last90days.sh
,jevs_global_det_atmos_grid2grid_precip_plots_last31days.sh
,jevs_global_det_atmos_grid2grid_precip_plots_last90days.sh
,jevs_global_det_atmos_grid2grid_pres_levs_plots_last31days.sh
,jevs_global_det_atmos_grid2grid_pres_levs_plots_last90days.sh
,jevs_global_det_atmos_grid2grid_sea_ice_plots_last31days.sh
,jevs_global_det_atmos_grid2grid_sea_ice_plots_last90days.sh
,jevs_global_det_atmos_grid2grid_snow_plots_last31days.sh
,jevs_global_det_atmos_grid2grid_snow_plots_last90days.sh
,jevs_global_det_atmos_grid2grid_sst_plots_last31days.sh
,jevs_global_det_atmos_grid2grid_sst_plots_last90days.sh
,jevs_global_det_atmos_grid2obs_pres_levs_plots_last31days.sh
,jevs_global_det_atmos_grid2obs_pres_levs_plots_last90days.sh
,jevs_global_det_atmos_grid2obs_ptype_plots_last31days.sh
,jevs_global_det_atmos_grid2obs_ptype_plots_last90days.sh
,jevs_global_det_atmos_grid2obs_sfc_plots_last31days.sh
,jevs_global_det_atmos_grid2obs_sfc_plots_last90days.sh