Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/update_mailto #543

Merged

Conversation

malloryprow
Copy link
Contributor

Note to developers: You must use this PR template!

Description of Changes

This updates MAILTO to reflect the current state of EVS developers and project leads.

Closes #542.

Developer Questions and Checklist

  • Is this a high priorty PR? If so, why and is there a date it needs to be merged by?

No

  • Do you have any planned upcoming annual leave/PTO?

Full day 9/13, half day afternoon 9/16, and full day 9/20

  • Are there any changes needed for when the jobs are supposed to run?

N/A

  • The code changes follow NCO's EE2 Standards.
  • Developer's name is removed throughout the code and have used ${USER} where necessary throughout the code.
  • References the feature branch for HOMEevs are removed from the code.
  • J-Job environment variables, COMIN and COMOUT directories, and output follow what has been defined for EVS.
  • Jobs over 15 minutes in runtime have restart capability.
  • If applicable, changes in the dev/drivers/scripts or dev/modulefiles have been made in the corresponding ecf/scripts and ecf/defs/evs-nco.def?
  • Jobs contain the approriate file checking and don't run METplus for any missing data.
  • Code is using METplus wrappers structure and not calling MET executables directly.
  • Log is free of any ERRORs or WARNINGs.

Testing Instructions

Not sure if we want to test anything with this. We could test doing fake path for something to see the emails work, but I don't want to send anyone emails unnecessarily about missing data when it is fake. @AndrewBenjamin-NOAA is also on leave and I don't know if we want to clog up his inbox more. We could also wait till he returns to do a test to make sure he gets the emails.

Copy link
Contributor

@AliciaBentley-NOAA AliciaBentley-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed all of the changes made in this PR. All of the EVS Regional components have been accounted for and updated, and employees who are no longer at EMC have been replaced with current employees. I approve this PR to be merged!

CC @malloryprow @PerryShafran-NOAA

Copy link
Contributor

@PerryShafran-NOAA PerryShafran-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good! I approve this PR to be merged.

@PerryShafran-NOAA PerryShafran-NOAA merged commit 9bf8386 into NOAA-EMC:develop Sep 5, 2024
@malloryprow malloryprow deleted the feature/update_mailto branch September 6, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MAILTO recipients
3 participants