Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compare sql scripts with survey branch scripts #71

Open
4 tasks
sgaichas opened this issue Jun 20, 2024 · 2 comments
Open
4 tasks

compare sql scripts with survey branch scripts #71

sgaichas opened this issue Jun 20, 2024 · 2 comments

Comments

@sgaichas
Copy link
Member

sgaichas commented Jun 20, 2024 •
edited
Loading

  • obtain basic sql scripts from ESB
  • compare with survdat sql pulls
    • same tables?
    • same columns?
@sgaichas sgaichas converted this from a draft issue Jun 20, 2024
@andybeet
Copy link
Member

@sgaichas requested sample scripts from ESB on june 20

@andybeet
Copy link
Member

After reviewing data.table::merge function, (which is the method used in get_survdat_data to join tables obtained from queries)
i am a little concerned. From my understanding this function used without arguments (which is how it appears in the code) is an inner join.

Maybe this is the correct type of join to use. I'm not sure yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
survdat review and updates
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgaichas @andybeet