diff --git a/.github/workflows/link-checker-pr.yml b/.github/workflows/link-checker-pr.yml index e0ff799..a4991f1 100644 --- a/.github/workflows/link-checker-pr.yml +++ b/.github/workflows/link-checker-pr.yml @@ -35,4 +35,4 @@ jobs: - name: Check all this file's additions for broken links run: | export base_sha=$(git rev-parse ${{ github.sha }}^) - git diff -U0 ${base_sha} ${{ github.event.pull_request.head.sha }} -- ${{ matrix.file }} | grep -v "+++" | grep "^+" | cut -c 2- | ./lychee --exclude nlesc.sharepoint.com --exclude support.posit.co --exclude www.intel.com --exclude reddit.com - + git diff -U0 ${base_sha} ${{ github.event.pull_request.head.sha }} -- ${{ matrix.file }} | grep -v "+++" | grep "^+" | cut -c 2- | ./lychee --exclude nlesc.sharepoint.com --exclude support.posit.co --exclude www.intel.com --exclude reddit.com --exclude jsfiddle.net - diff --git a/.github/workflows/link-checker.yml b/.github/workflows/link-checker.yml index bab6a2a..091fc8f 100644 --- a/.github/workflows/link-checker.yml +++ b/.github/workflows/link-checker.yml @@ -16,7 +16,7 @@ jobs: id: lychee with: # note: args has a long default value; when you override it, make sure you don't accidentally forget to include the default options you want! see https://github.com/lycheeverse/lychee-action/blob/master/action.yml - args: --verbose --no-progress './**/*.md' './**/*.html' './**/*.rst' --accept '100..=103,200..=299, 429' --exclude nlesc.sharepoint.com --exclude support.posit.co --exclude www.intel.com --exclude reddit.com + args: --verbose --no-progress './**/*.md' './**/*.html' './**/*.rst' --accept '100..=103,200..=299, 429' --exclude nlesc.sharepoint.com --exclude support.posit.co --exclude www.intel.com --exclude reddit.com --exclude jsfiddle.net env: # This token is included to avoid github.com requests to error out with status 429 (too many requests). It only works for GitHub requests (also other GitHub REST API calls), not for the rest of the web. GITHUB_TOKEN: ${{secrets.TOKEN_GITHUB}} diff --git a/language_guides/javascript.md b/language_guides/javascript.md index 3331ff9..6770351 100644 --- a/language_guides/javascript.md +++ b/language_guides/javascript.md @@ -201,7 +201,7 @@ Also have a look at the [Airbnb JavaScript Style Guide](https://github.com/airbn For more in-depth analyses, you can use a code quality and analysis tool. -- [SonarCloud](https://sonarcloud.io) is an open platform to manage code quality which can also show code coverage and count test results over time. It easily [integrates with GitHub](https://github.com/apps/sonarcloud). +- [SonarCloud](https://sonarcloud.io) is an open platform to manage code quality which can also show code coverage and count test results over time. It easily [integrates with GitHub](https://github.com/marketplace/sonarcloud). - [Codacy](https://www.codacy.com) can analyze [many different languages](https://docs.codacy.com/getting-started/supported-languages-and-tools/) using open source tools. It also offers [GitHub integration](https://docs.codacy.com/repositories-configure/integrations/github-integration/). - [Code climate](https://codeclimate.com/quality) can analyze JavaScript (and Ruby, PHP). Can analyze Java (best supported), C, C++, Python, JavaScript and TypeScript.