Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render_equation.cu没有被使用? #46

Open
moonChen2 opened this issue Dec 11, 2024 · 1 comment
Open

render_equation.cu没有被使用? #46

moonChen2 opened this issue Dec 11, 2024 · 1 comment

Comments

@moonChen2
Copy link

在你们最新的代码中,我发现render_equation.cu似乎没有被使用。
在ext.cpp中,并没有将他暴露出来。如果我的想法有误,请指正,如果确实没有使用,我建议在github仓库中删除这两个文件。

PYBIND11_MODULE(TORCH_EXTENSION_NAME, m) {
m.def("rasterize_gaussians", &RasterizeGaussiansCUDA);
m.def("rasterize_gaussians_backward", &RasterizeGaussiansBackwardCUDA);
m.def("mark_visible", &markVisible);
}

@NWPU66
Copy link

NWPU66 commented Dec 16, 2024

Yes, they do not use them.
BTW, file neilf_composite.py is not used too.

they create a new SH property named "visibility", to represent the shadow term in file neilf_composite.py.

    @property
    def get_visibility(self):   # 只在neilf_composite中用到,但是neilf_composite没有用
        """SH"""
        visibility_dc = self._visibility_dc
        visibility_rest = self._visibility_rest
        return torch.cat((visibility_dc, visibility_rest), dim=1)

however, they do not used file neilf_composite.py. maybe in their earily version, they use SH property to fit shadow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants