Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of internal zScore into output reports #11

Open
mharms opened this issue Dec 4, 2015 · 2 comments
Open

Inclusion of internal zScore into output reports #11

mharms opened this issue Dec 4, 2015 · 2 comments

Comments

@mharms
Copy link
Contributor

mharms commented Dec 4, 2015

Hi,
This isn't an "issue" per se. I thought it would potentially be very useful if the QCReport output included the z-scores that are calculated internally as part of SliceChecker and InterlaceChecker for deciding if a frame should be excluded. That way, one can quickly see how close a given frame was to exclusion, and more readily calibrate an appropriate set of thresholds to use for a given set of data.

So, I've implemented the changes necessary in the SliceChecker and InterlaceChecker code to store those z-scores while they are computed, and then later output them into the QCReport.

I'm not familiar with how to formally use GitHub for this sort of thing, so I haven't forked the code and created a pull request. But I'm mentioning this because if a DTIPrep developer is interested in incorporating these features, I'm more than happy to share the code.

cheers,
-Mike H.

@styner
Copy link
Member

styner commented Dec 6, 2015

That's great, thanks for the edits. How did you get the code, I assume via "git clone"? simply commit and push the code back to the repository where we can approve it and it will be included in the repository.
Alternatively, just send the modified code to me or Juan.

Thanks
Martin

@juanprietob
Copy link
Contributor

Hello Mike,
This aritcle explains the procedure to fork a repository, modify the code and submit a pull request.
It is the preferred way. You will appear as a contributor to DTIPprep.
Let me know if you have any questions.
Best,
Juan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants