Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger rerunning tests on master whenever the container gets rebuilt #183

Open
hlapp opened this issue May 4, 2016 · 2 comments
Open

Comments

@hlapp
Copy link
Member

hlapp commented May 4, 2016

Changes in containers on Docker Hub that the rpopgen container depends on are set to trigger a rebuild of the rpopgen container. When that happens, packages are installed into the container with their latest versions (on CRAN or Github, depending on what the Dockerfile says), which may bring API changes compared to when the tests were last run (and presumably succeeded).

Whether such API changes necessitate fixes in the Rmarkdown code snippets will only be known when the tests are rerun. If a contributor branches off, they take the potential issues into their branch, potentially dooming the test run on their build until the necessary fixes are included (which requires either advanced Git commands such as rebasing or cherry-picking, or cumbersome workarounds). Therefore, to be able to act on such issues before it hits contributors, the tests on master would need to be automatically rerun whenever the container on Docker Hub is rebuilt.

See #182 for a case in point.

@zkamvar
Copy link
Contributor

zkamvar commented May 4, 2016

One issue that definitely will arise is the fact that our attempt at a unifying git framework (git2r), currently does not have methods for cherry-pick or rebase. That being said, updating via merge, while it does create unnecessary commits, it will still work for the majority of submissions.

@zkamvar
Copy link
Contributor

zkamvar commented May 4, 2016

I wonder if we could use the Docker build to trigger a commit that, say, changes the date in the DESCRIPTION file on the master branch, effectively triggering a rebuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants