Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling static images on website? #134

Open
zkamvar opened this issue Feb 9, 2016 · 1 comment
Open

Handling static images on website? #134

zkamvar opened this issue Feb 9, 2016 · 1 comment

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Feb 9, 2016

How should we handle static images on the website?

Should we include an images/ directory? The only thing that would go awry is that if I add an image in CONTRIBUTING.md, is that the link will be broken on the master branch.

@hlapp
Copy link
Member

hlapp commented Feb 9, 2016

Should we include an images/ directory? The only thing that would go awry is that if I add an image in CONTRIBUTING.md, is that the link will be broken on the master branch.

Why would it? Instead, I think we'd just need to tweak the Makefiles to copy the images/ folder into the build directory (similarly to what happens with the data/ directory). Does't strike me as difficult - why don't you go ahead and add the directory, and if you're not sure how to tweak the Makefiles, I'll take a look at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants