Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agnostic unit conversion backend #394

Closed
bekozi opened this issue Nov 13, 2015 · 6 comments
Closed

Agnostic unit conversion backend #394

bekozi opened this issue Nov 13, 2015 · 6 comments
Assignees
@bekozi
Labels
enhancement
Milestone
v1.3.0

Comments

@bekozi
Copy link
Contributor

bekozi commented Nov 13, 2015

who: @ocefpaf, @rsignell-usgs

https://github.com/SciTools/cf_units
@bekozi bekozi self-assigned this Nov 13, 2015
@ocefpaf
Copy link

ocefpaf commented Nov 13, 2015

I am biased by recommending this change 😉

Bare in mind that we have this SciTools/cf-units#30 limitation at the moment.

@bekozi
Copy link
Contributor Author

bekozi commented Nov 13, 2015

Noted. Thanks for the heads up! It should be possible to make unit conversion agnostic to the library.

@ocefpaf
Copy link

ocefpaf commented Nov 13, 2015

Awesome! 👍

@bekozi bekozi changed the title Consider transitioning to "cf_units" Agnostic unit conversion backend Nov 17, 2015
@bekozi bekozi mentioned this issue Nov 17, 2015
Closed
2 tasks
bekozi added a commit that referenced this issue Dec 8, 2015
@bekozi
ENH: Added support for "cf_units" #394, #322
d16b995 
- Refactored unit conversion to support "cfunits" and "cf_units".
- "cf_units" does not support in-place conversions.
- Bounds are now loaded independently from value when using a request
  dataset for on-demand loading.
bekozi added a commit that referenced this issue Dec 8, 2015
@bekozi
ENH: Environment and ocigs.__init__ changes #394, #322
2737dd8
@bekozi
Copy link
Contributor Author

bekozi commented Dec 8, 2015

cf_units and cfunits-python are both supported. There are few syntactical differences between the two software. In-place conversion support should be added for cf_units.

@bekozi bekozi closed this as completed Dec 8, 2015
@bekozi bekozi added this to the v1.3.0 milestone Dec 8, 2015
@ocefpaf
Copy link

ocefpaf commented Dec 8, 2015

Awesome! (You work fast! It is hard to keep up.)

@bekozi
Copy link
Contributor Author

bekozi commented Dec 8, 2015

cf_units made it easy! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bekozi bekozi

Labels
enhancement
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
2 participants
@bekozi @ocefpaf