Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NCAR/wrf_hydro_nwm_public
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.3.0
Choose a base ref
...
head repository: NCAR/wrf_hydro_nwm_public
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.

Commits on Sep 21, 2022

  1. New Feature: trunk/NDHMS has been moved to src/ directory to follow m…

    …odern
    
    build directory structures, allow for a CMakelist in the top directory and
    better testing integration. trunk/NDHMS is currently a symlink to allow time
    for users to switch over. CMakeLists and Makefiles have been modified.
    scrasmussen authored and rcabell committed Sep 21, 2022
    Copy the full SHA
    57dce00 View commit details

Commits on Oct 4, 2022

  1. bugfix: fixes issue #653 so Cray compiler now builds. Removes comma a…

    …fter write statement and changes A*-B*C statements to A*(-B)*C.
    scrasmussen authored and rcabell committed Oct 4, 2022
    Copy the full SHA
    4c32e10 View commit details

Commits on Oct 11, 2022

  1. fixed NCO Bugzilla 1156, [Bug 1156] New: Missing debug, install and t…

    …est targets in makefiles. Per NCO's Implementation Standard, five critical targets should be defined in the makefile: all, debug, install, clean and test. See https://www.nco.ncep.noaa.gov/idsb/implementation_standards/Implementation%20Standards%20v10.2.pdf?.
    zhengtaocui authored and rcabell committed Oct 11, 2022
    Copy the full SHA
    9ade8fa View commit details

Commits on Oct 19, 2022

  1. Enhancement: removed include statements

    Remove include statements (other than the netcdf/mpi ones). Moved what would have been included into modules. This follows modern Fortran practices and has numerous benefits. Modified and tested both CMake and Makefile files. (#655)
    scrasmussen authored Oct 19, 2022
    Copy the full SHA
    f9fd317 View commit details

Commits on Nov 1, 2022

  1. Add scrape of outer edge of domain so water doesn't pile up. (#658)

    Add scrape of outer edge of domain so water doesn't pile up
    aubreyd authored Nov 1, 2022
    Copy the full SHA
    718ec64 View commit details

Commits on Nov 2, 2022

  1. TG goes to 0 when all remaining snow melts during crocus call. Set ba…

    …ckground temperature fields to freezing instead of 0.
    aubreyd authored and scrasmussen committed Nov 2, 2022
    Copy the full SHA
    81e76de View commit details

Commits on Nov 3, 2022

  1. Copy the full SHA
    5ab0af5 View commit details

Commits on Nov 7, 2022

  1. Crocus output fixes (#663)

    * Updates to scale and min/max values for Crocus outputs.
    
    * Adjust crocus output fill values and scale/min/max metadata.
    
    * Updates to nodata cell treatments.
    
    * A few extra output updates and fix to Crocus to reset GLACR and smc after meltout.
    
    * Revert standalone accet variable tracking - doesn't seem necessary.
    
    * A couple of patches for problem values coming from crocus.
    aubreyd authored Nov 7, 2022
    Copy the full SHA
    fabc221 View commit details

Commits on Dec 13, 2022

  1. Copy the full SHA
    1a043af View commit details

Commits on Jan 18, 2023

  1. Bump certifi from 2019.6.16 to 2022.12.7 in /tests/local

    Bumps [certifi](https://github.com/certifi/python-certifi) from 2019.6.16 to 2022.12.7.
    - [Release notes](https://github.com/certifi/python-certifi/releases)
    - [Commits](certifi/python-certifi@2019.06.16...2022.12.07)
    
    ---
    updated-dependencies:
    - dependency-name: certifi
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and rcabell committed Jan 18, 2023
    Copy the full SHA
    7c31c59 View commit details

Commits on Jan 24, 2023

  1. Bug fix to ACSNOW calculation to output as accumulated depth (not rat…

    …e). Add to retro IO option.
    aubreyd authored and rcabell committed Jan 24, 2023
    Copy the full SHA
    0500f24 View commit details

Commits on Feb 1, 2023

  1. Crocus has been turned into a compile time option that can be turned …

    …off, default is on.
    
    Changes have been made to files for the CMake and Makefile build systems.
    Crocus licensing info has been added to the README.
    scrasmussen authored and rcabell committed Feb 1, 2023
    Copy the full SHA
    2b0ee31 View commit details
  2. routing bugfix: removed CHANN_K from debug print statement. The varia…

    …ble is unitialized and can change values every time executable is run. (#668)
    
    config debug: fixes in read_crocus_namelist subroutine
    scrasmussen authored Feb 1, 2023
    Copy the full SHA
    b31c78f View commit details
  3. Copy the full SHA
    72b6f34 View commit details

Commits on Feb 9, 2023

  1. Don't report success if underlying Make failed

    The `make; make install` command will report success even if the first
    Make process failed. The result of this compound expression is passed to
    the code that prints success/failure to the user.
    
    Fixed by switching to `make && make install` to chain the result codes.
    rcabell committed Feb 9, 2023
    Copy the full SHA
    f76d4bc View commit details
  2. Import isnan() from IEEE_ARITHMETIC

    Use IEEE_ARITHMETIC's ieee_is_nan() instead of compiler-specific
    intrinsics for broader compatibility.
    rcabell committed Feb 9, 2023
    Copy the full SHA
    fdbbc9d View commit details
  3. Update CMake with proper MPI and PGI/NVHPC support

    * Use find_package(MPI required) instead of overriding compiler binaries
    * Add support for PGI (and NVHPC) in CMake build system
    * Update minimum CMake to 3.0
    rcabell committed Feb 9, 2023
    Copy the full SHA
    a341277 View commit details
  4. Copy the full SHA
    9175ab4 View commit details

Commits on Feb 15, 2023

  1. Copy the full SHA
    4f181e6 View commit details

Commits on Mar 1, 2023

  1. Enhancement: compiler info added to NetCDF restart output (#678)

    * enhancement: add compiler info to all netcdf output files
    scrasmussen authored Mar 1, 2023
    Copy the full SHA
    5af61ea View commit details
  2. Copy the full SHA
    e4be0a2 View commit details
  3. Update Nudging IO to netCDF NF90 API (#684)

    * Update nudging_io to NF90 API
    * Since NetCDF subroutines have been converted to nf90 we can remove the 'include netcdf.inc' statements
    
    Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com>
    rcabell and scrasmussen authored Mar 1, 2023
    Copy the full SHA
    1c540f9 View commit details

Commits on Mar 2, 2023

  1. Changes to reflect the renaming of the directory trunk/NDHMS to src (#…

    …681)
    
    * Changes to represent the renaming of of the directory trunk/NDHMS to src
    * Adding build directory to .gitignore
    scrasmussen authored Mar 2, 2023
    Copy the full SHA
    85078a0 View commit details

Commits on May 24, 2023

  1. Bump requests from 2.20.0 to 2.31.0 in /tests/local (#692)

    Bumps [requests](https://github.com/psf/requests) from 2.20.0 to 2.31.0.
    - [Release notes](https://github.com/psf/requests/releases)
    - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
    - [Commits](psf/requests@v2.20.0...v2.31.0)
    
    ---
    updated-dependencies:
    - dependency-name: requests
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored May 24, 2023
    Copy the full SHA
    1f39d6e View commit details

Commits on May 25, 2023

  1. Enhancement: quick CMake build instructions (#691)

    * Creating new directory structure for expanded documentation within the github repo and adding quick build documentation to the README. Removed large netcdf file support line from unsupported functionality table.
    scrasmussen authored May 25, 2023
    Copy the full SHA
    09bb6c1 View commit details

Commits on Jun 7, 2023

  1. bumping actions checkout and upload-artifact to v3 because github act…

    …ions Node.js 12 has been depricated, current version 16 (#693)
    scrasmussen authored Jun 7, 2023
    Copy the full SHA
    5beb90a View commit details
  2. Auto-generation and posting of model difference plots for CI tests (#674

    )
    
    * Added scripts for plotting test candidate diffs and uploading diff images to the PR comment
    * Added diff plotting with limited plot generation. Modified test-pr.yml temporarily to develop attaching plots to PR.
    * Added logic to pull a list of channel and lake ids to plot from the test domain file, if there are differences to plot
    * Archive diff plots
    
    ---------
    
    Co-authored-by: Andrew Gaydos <gaydos@yar.rap.ucar.edu>
    Co-authored-by: Ryan Cabell <rcabell@ucar.edu>
    Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com>
    4 people authored Jun 7, 2023
    Copy the full SHA
    953c343 View commit details

Commits on Jun 9, 2023

  1. Bump pillow from 9.2.0 to 9.3.0 in /tests/local/utils (#695)

    Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.2.0 to 9.3.0.
    - [Release notes](https://github.com/python-pillow/Pillow/releases)
    - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
    - [Commits](python-pillow/Pillow@9.2.0...9.3.0)
    
    ---
    updated-dependencies:
    - dependency-name: pillow
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jun 9, 2023
    Copy the full SHA
    38e47f1 View commit details

Commits on Jun 12, 2023

  1. bugfix: release and debug CMake build types (#669)

    * bugfix: release and debug build types now choose correct optimization flags
    * adding backtrace/traceback to Debug mode
    * cmake: added build flags for Cray
    * cmake: -fallow-argument-mismatch was required to build with GCC+MPICH on Gust, a Cray cluster
    * If gfortran is 9+ then use the -fallow-argument-mismatch
    * Per Ryan's advice, added 'LANGUAGES Fortran' to CMake project statement so it won't fail if there is no C++ compiler present.
    
    ---------
    
    Co-authored-by: Soren Rasmussen <soren@ucar.edu>
    Co-authored-by: Ryan Cabell <rcabell@ucar.edu>
    3 people authored Jun 12, 2023
    Copy the full SHA
    4864147 View commit details

Commits on Jun 21, 2023

  1. Copy the full SHA
    05bd385 View commit details
  2. Alma tweaks (#697)

    * Add support for RedHat-style separated f90 modules to CMake build
    * Add support for RH-style f90 mods to legacy build
    rcabell authored Jun 21, 2023
    Copy the full SHA
    4a0b8a2 View commit details

Commits on Jul 5, 2023

  1. bugfix: unallocated variables (#700)

    * Running with -fcheck=all lead to errors of the following variables not being allocated: gw_buck_loss, RT_DOMAIN(did)%LLINKID, gw2d, qgw_chanrt, and vis_icealb. Also switch crocus variable from optional to allocatable.
    scrasmussen authored Jul 5, 2023
    Copy the full SHA
    97f245d View commit details

Commits on Aug 17, 2023

  1. Adding ctest structure and two basic tests. Adding ability to run $ m…

    …ake croton to download Croton testcase, extract tarball and setup. Makefile copied to Run directory. Cleanup of Run directory handled differently. (#702)
    
    Croton CMake tests: adding ability to choose the different test options as a Makefile target
    scrasmussen authored Aug 17, 2023
    Copy the full SHA
    a821261 View commit details
  2. Bump certifi from 2022.12.7 to 2023.7.22 in /tests/local (#703)

    Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.12.7 to 2023.7.22.
    - [Commits](certifi/python-certifi@2022.12.07...2023.07.22)
    
    ---
    updated-dependencies:
    - dependency-name: certifi
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Aug 17, 2023
    Copy the full SHA
    5d9e489 View commit details

Commits on Oct 12, 2023

  1. Copy the full SHA
    67d879c View commit details
  2. Copy the full SHA
    d58ae32 View commit details
  3. Update code to fix Cray-related compiler issues

    * Use assumed shape / volatile arrays with ext libs
    * Replace timestep multiple check with mod operator
    rcabell committed Oct 12, 2023
    Copy the full SHA
    7c589c9 View commit details
  4. Optimize inefficient MPI routines

    * Convert MPP_LAND p2p MPI to collectives
    * Remove unneeded mpp_land_sync() calls
    rcabell committed Oct 12, 2023
    Copy the full SHA
    dcdf382 View commit details

Commits on Oct 17, 2023

  1. Issue 714 Bugfix: need to check if optional arguments are present bef…

    …ore assigning them to a variable
    scrasmussen authored and rcabell committed Oct 17, 2023
    Copy the full SHA
    3deb607 View commit details

Commits on Feb 20, 2024

  1. initial version of CITATION.cff

    scrasmussen authored and rcabell committed Feb 20, 2024
    Copy the full SHA
    4851a86 View commit details
  2. Adding the OrcIDs I could find

    scrasmussen authored and rcabell committed Feb 20, 2024
    Copy the full SHA
    b97bf47 View commit details
  3. Adding authors from the technical document citation, listed using Goc…

    …his first then alphabetically ordered
    scrasmussen authored and rcabell committed Feb 20, 2024
    Copy the full SHA
    100c551 View commit details
  4. Bump urllib3 from 1.26.5 to 1.26.18 in /tests/local

    Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.5 to 1.26.18.
    - [Release notes](https://github.com/urllib3/urllib3/releases)
    - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
    - [Commits](urllib3/urllib3@1.26.5...1.26.18)
    
    ---
    updated-dependencies:
    - dependency-name: urllib3
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and rcabell committed Feb 20, 2024
    Copy the full SHA
    a97ff7e View commit details
  5. Bump pillow from 9.3.0 to 10.2.0 in /tests/local/utils

    Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.3.0 to 10.2.0.
    - [Release notes](https://github.com/python-pillow/Pillow/releases)
    - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
    - [Commits](python-pillow/Pillow@9.3.0...10.2.0)
    
    ---
    updated-dependencies:
    - dependency-name: pillow
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and rcabell committed Feb 20, 2024
    Copy the full SHA
    7afc6b3 View commit details

Commits on Mar 22, 2024

  1. Add capability to define name of forcing variables in namelist.hrldas…

    …; add optional snow to forcing
    Michael Barlage authored and scrasmussen committed Mar 22, 2024
    Copy the full SHA
    ecec5e9 View commit details
  2. add liquid fraction as forcing option

    Michael authored and scrasmussen committed Mar 22, 2024
    Copy the full SHA
    060de6b View commit details
  3. WRF-Hydro now reads in LQFRC (liquid water fraction) when HRLDAS forc…

    …ing is read in, currently occuring for forcing types 1,2,6 when READFORC_HRLDAS is called
    scrasmussen committed Mar 22, 2024
    Copy the full SHA
    430f06a View commit details
  4. Reading in

    the SNOW variable as well. The liquid water fraction is now used to set SNOWBL if SNOW is not present.
    scrasmussen committed Mar 22, 2024
    Copy the full SHA
    6871aa5 View commit details
  5. Copy the full SHA
    fb6f5a4 View commit details
  6. The forcing variables names that have been added to namelist.hrldas a…

    …re now passed around to all other IO functions
    scrasmussen committed Mar 22, 2024
    Copy the full SHA
    42114d7 View commit details
Showing 739 changed files with 43,510 additions and 14,196 deletions.
65 changes: 32 additions & 33 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -82,9 +82,9 @@ which changes the answer must be isolated as much as possible into its own pull
#### Bug fixes
All bug fixes must address a specific [GitHub
issue](https://github.com/NCAR/wrf_hydro_nwm_public/issues). Only issues labeled with ["community
dev"](https://github.com/NCAR/wrf_hydro_nwm_public/labels/community%20dev) are open to community
contributions. The majority of issues will be open to community contributions, but some cases may
require more careful handling. Issues without the "community dev" label are either still being
dev"](https://github.com/NCAR/wrf_hydro_nwm_public/labels/community%20dev) are open to community
contributions. The majority of issues will be open to community contributions, but some cases may
require more careful handling. Issues without the "community dev" label are either still being
investigated, are of broad scope, or involve changes to code that is actively being developed internally.

All code changes to address issues must be submitted using a pull request, and the corresponding
@@ -109,46 +109,45 @@ harmony among the various NCAR, NOAA, and WRF-Hydro community research efforts.

### Checklist for new feature contributions
#### You should have the following to submit a new feature contribution to the WRF-Hydro code base:
1. A WRF-Hydro team point of contact (POC). Early in your development process, it is always a good idea
to reach out to the WRF-Hydro team and find a good POC for your new feature. This person will help
keep you informed of new developments as they may relate to your feature, advise you on which branches
to keep current with (if other than master), and provide pointers on requirements.
2. New feature code integrated in with the latest WRF-Hydro master branch (or other as advised by your
WRF-Hydro POC). This merged code should exist in your own fork, but can be in your own master branch or
1. A WRF-Hydro team point of contact (POC). Early in your development process, it is always a good idea
to reach out to the WRF-Hydro team and find a good POC for your new feature. This person will help
keep you informed of new developments as they may relate to your feature, advise you on which branches
to keep current with (if other than main), and provide pointers on requirements.
2. New feature code integrated in with the latest WRF-Hydro main branch (or other as advised by your
WRF-Hydro POC). This merged code should exist in your own fork, but can be in your own main branch or
a separate feature branch.
* *TIP #1*: It is always a good strategy to pull the latest WRF-Hydro master code into your branch
fairly often throughout your development cycle. Leaving months of code changes to merge at the end of
your development cycle can result in lots of merge conflicts, time-consuming manual edits, and higher
* *TIP #1*: It is always a good strategy to pull the latest WRF-Hydro main code into your branch
fairly often throughout your development cycle. Leaving months of code changes to merge at the end of
your development cycle can result in lots of merge conflicts, time-consuming manual edits, and higher
potential for making errors.
* *TIP #2*: New code should follow the
[WRF-Hydro code contribution guidelines](https://github.com/NCAR/wrf_hydro_nwm_public/blob/master/.github/CONTRIBUTING.md).
3. Documentation for your new feature. This should include (1) a simple summary in the release notes
(added to [NEWS.md](https://github.com/NCAR/wrf_hydro_nwm_public/blob/master/NEWS.md)), and (2) a
detailed description of the new feature suitable to be included within the
[WRF-Hydro Technical Description](https://ral.ucar.edu/sites/default/files/public/projects/wrf_hydro/technical-description-user-guide/wrf-hydro-v5.1.1-technical-description.pdf),
included as a new markdown document in the
[Doc](https://github.com/NCAR/wrf_hydro_nwm_public/tree/master/trunk/NDHMS/Doc)
* *TIP #2*: New code should follow the
[WRF-Hydro code contribution guidelines](https://github.com/NCAR/wrf_hydro_nwm_public/blob/main/.github/CONTRIBUTING.md).
3. Documentation for your new feature. This should include (1) a simple summary in the release notes
(added to [NEWS.md](https://github.com/NCAR/wrf_hydro_nwm_public/blob/main/NEWS.md)), and (2) a
detailed description of the new feature suitable to be included within the
[WRF-Hydro Technical Description](https://ral.ucar.edu/sites/default/files/public/projects/wrf_hydro/technical-description-user-guide/wrf-hydro-v5.1.1-technical-description.pdf),
included as a new markdown document in the
[Doc](https://github.com/NCAR/wrf_hydro_nwm_public/tree/main/trunk/NDHMS/Doc)
folder.
4. An updated
[standalone test case](https://ral.ucar.edu/projects/wrf_hydro/testcases) demonstrating how
your new feature works, based on one of the existing WRF-Hydro test cases (e.g., Croton). If you cannot
adapt an existing test case and need to create something new, please consult with your POC. The test
4. An updated
[standalone test case](https://ral.ucar.edu/projects/wrf_hydro/testcases) demonstrating how
your new feature works, based on one of the existing WRF-Hydro test cases (e.g., Croton). If you cannot
adapt an existing test case and need to create something new, please consult with your POC. The test
case should include:
* Domain and parameter files
* Namelists
* Example forcings if needed (idealized forcing use is OK)
* Test case documentation
5. Testing - you must clearly demonstrate that your new feature:
* Does no harm to the existing code (e.g., produces identical solutions EXCEPT when the new feature is
* Does no harm to the existing code (e.g., produces identical solutions EXCEPT when the new feature is
activated by a namelist or parameter setting).
* Fixes a documented issue (reference existing issue in the
* Fixes a documented issue (reference existing issue in the
[WRF-Hydro GitHub issue tracking](https://github.com/NCAR/wrf_hydro_nwm_public/issues) - this could also be a feature request).
* If model performance is improved, for example through more efficient IO, memory utilization, or other
* If model performance is improved, for example through more efficient IO, memory utilization, or other
software-specific improvements, it must be demonstrable and measurable.
* *TIP*: All pull requests go through automated CI testing, but for a new feature it is important to do
thorough testing ahead of time so you have a good sense of the model impacts and can explain/justify them.
* *TIP*: All pull requests go through automated CI testing, but for a new feature it is important to do
thorough testing ahead of time so you have a good sense of the model impacts and can explain/justify them.
Do not wait until automated CI testing to test your new feature.
6. A pull request from a branch on your fork to the WRF-Hydro master branch (or other as advised by your
WRF-Hydro POC). Make sure to also follow the specific
[WRF-Hydro pull request guidelines](https://github.com/NCAR/wrf_hydro_nwm_public/blob/master/.github/PULL_REQUEST_TEMPLATE.md).

6. A pull request from a branch on your fork to the WRF-Hydro main branch (or other as advised by your
WRF-Hydro POC). Make sure to also follow the specific
[WRF-Hydro pull request guidelines](https://github.com/NCAR/wrf_hydro_nwm_public/blob/main/.github/PULL_REQUEST_TEMPLATE.md).
39 changes: 12 additions & 27 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,37 +1,22 @@
If you haven't already, please review our [contributing guidelines](CONTRIBUTING.md) before opening your pull request.

Use this template to give a detailed message describing the change you want to make to the code.

The title of this pull request should be a brief "purpose" for this change.

--- Delete this line and those above before hitting "Create pull request" ---

TYPE: choose one of [bug fix, enhancement, new feature, feature removed, no impact, text only]

KEYWORDS: approximately 3 to 6 words (more is always better) related to your commit, separated by commas

SOURCE: Developer's name and affiliation
SOURCE: Developer's name and affiliation

DESCRIPTION OF CHANGES: One or more paragraphs describing problem, solution, and required changes.

ISSUE: The GitHub Issue that this PR addresses. For issue number 123, it would be:
```
Fixes #123
```

TESTS CONDUCTED: Explicitly state if regression, integration, or unit tests were run before submitting (do not include the CI tests automatically run by GitHub)

NOTES: Optional, as appropriate. Delete if not used. Included only once for new features requiring several merge cycles. Changes to default behavior are also note worthy.
ISSUE: The GitHub Issue that this PR addresses. For issue number 123, it would be `Fixes #123`

TESTS CONDUCTED: Explicitly state if regression, integration, or unit tests were run before submitting.

### Checklist
Merging the PR depends on following checklist being completed. Add `X` between each of the square
brackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment
on why below the bullet.
NOTES: Optional, as appropriate. Delete if not used.

- [ ] Closes issue #xxxx (An issue must exist or be created to be closed. The issue describes and documents the problem and general solution, the PR describes the technical details of the solution.)
- [ ] Tests added (unit tests and/or regression/integration tests)
- [ ] Backwards compatible
- [ ] Requires new files? If so, how to generate them.
- [ ] Documentation included
- [ ] Short description in the Development section of `NEWS.md`
<!--
ITEMS THAT MIGHT BE USEFUL TO CONSIDER
- Closes issue #xxxx
- Tests added (unit tests and/or regression/integration tests)
- Backwards compatible
- Documentation included
- Short description in the Development section of `NEWS.md`
--->
Loading