Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip the columns created by stats & bin by level when writing obs sequences #51

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

hkershaw-brown
Copy link
Member

drop the columns created by the stats module when writing out observation sequences.
Note the write is a copy of obs_seq.df so the obs_seq.df is not modified by the write.

columns dropped are
"prior/posterior_bias", "prior/posterior_sq_err", "prior/posterior_totalvar", "midpoint" , "vlevels"

tests added:

  • run stats then write
  • bin by level then write (on obs_seq.out and obs_seq.final)

fixes: #49

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.75%. Comparing base (ba94f5c) to head (c24dc4d).

Files with missing lines Patch % Lines
src/pydartdiags/obs_sequence/obs_sequence.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   70.60%   70.75%   +0.14%     
==========================================
  Files           4        4              
  Lines         796      800       +4     
==========================================
+ Hits          562      566       +4     
  Misses        234      234              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hkershaw-brown hkershaw-brown merged commit 1abdc61 into main Feb 13, 2025
2 checks passed
@hkershaw-brown hkershaw-brown deleted the write-after-stats branch February 13, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

writing obs sequences after calculating stats
2 participants