Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat request: Plot profiles of RMSE and bias of obs with the height vertical coordinate (and general vertical coordinate handling) #14

Closed
icastorm opened this issue Aug 12, 2024 · 4 comments

Comments

@icastorm
Copy link
Contributor

Description

While most observations in DART are likely to use the pressure vertical coordinate, the height vertical coordinate is also often used. In my previous experiments, for example, I used height exclusively. Some sets of obs may even use both, depending on the types of observations being used.

Currently, the profile plot can only handle observations with the pressure vertical coordinate. I'd like to see the plotting function able to handle obs_seq files with the height vertical coordinate as well.

Solution(s)

  • I'd add an input in plots.plot_profile that determines the vertical coordinate to be plotted, with a default value of pressure coordinates. Only observation types that use the selected vertical coordinate will be plotted.
@icastorm
Copy link
Contributor Author

This is a fairly easy add, so I can work on a branch with this feature and test it some time this week!

@icastorm
Copy link
Contributor Author

icastorm commented Aug 19, 2024

I have a version of this working, will look at getting the plotting tests up to speed next. Currently, the new version of plot_profile defaults to using pressure coordinates, but can take in any vert_unit value desired. It then slices the given data down to just the rows that use the selected coordinate and returns an error if none are found.

@icastorm
Copy link
Contributor Author

It's been a bit, but I'd like to get back on the horse on this project this week! Will be working on getting the plotting tests up to speed here after updating my fork.

@hkershaw-brown
Copy link
Member

fixed by #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants