Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suite-part list is wrong #634

Open
dustinswales opened this issue Jan 29, 2025 · 5 comments · May be fixed by #633
Open

Suite-part list is wrong #634

dustinswales opened this issue Jan 29, 2025 · 5 comments · May be fixed by #633
Labels

Comments

@dustinswales
Copy link
Collaborator

Description

The "suite part list" order (e.g. group order) in the host API are sorted alphabetically, not as written into the Suite Definition File.

Steps to Reproduce

Using the capgen_test, change physics1 in temp_suite.xml to radiation, run the tests and look at the suite_part_list in the host Cap:
Image

The order is incorrect

@gold2718
Copy link
Collaborator

I'm not sure "incorrect" is accurate here. There was no requirement for this before I wrote it (did prebuild even have this feature before?).
Inconvenient might be a better term.

@climbfuji
Copy link
Collaborator

Is this a problem? For example, when running through all groups (when the ccpp_physics_run call is executed without group=...), does it follow the order in the list? If that were the case, then it would be a problem.

prebuild doesn't use a list, but it always follows the order of the groups and schemes in groups.

@gold2718
Copy link
Collaborator

Is this a problem?

Absolutely not. It was not important before but if someone is going to rely on an ordering, we just need to implement the desired ordering, document it and test it (which I guess #633 is doing). Using the SDF ordering seems sensible to me.

@climbfuji
Copy link
Collaborator

I think it is imperative that when running through all groups in one go, the order in the suite is maintained. In any and all of the GFS suites, radiation runs first, then the "other physics". There are strict dependencies between these groups (radiation does certain things that the other physics rely on). That applies to all phases, too (init, timestep_init, ...).

@dustinswales
Copy link
Collaborator Author

Ditto what Dom said. This and #629 are critical to ensure the SDF matches the suite cap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants