-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suite-part list is wrong #634
Comments
I'm not sure "incorrect" is accurate here. There was no requirement for this before I wrote it (did prebuild even have this feature before?). |
Is this a problem? For example, when running through all groups (when the ccpp_physics_run call is executed without prebuild doesn't use a list, but it always follows the order of the groups and schemes in groups. |
Absolutely not. It was not important before but if someone is going to rely on an ordering, we just need to implement the desired ordering, document it and test it (which I guess #633 is doing). Using the SDF ordering seems sensible to me. |
I think it is imperative that when running through all groups in one go, the order in the suite is maintained. In any and all of the GFS suites, radiation runs first, then the "other physics". There are strict dependencies between these groups (radiation does certain things that the other physics rely on). That applies to all phases, too (init, timestep_init, ...). |
Ditto what Dom said. This and #629 are critical to ensure the SDF matches the suite cap |
Description
The "suite part list" order (e.g. group order) in the host API are sorted alphabetically, not as written into the Suite Definition File.
Steps to Reproduce
Using the capgen_test, change
![Image](https://private-user-images.githubusercontent.com/13949033/407919769-6794e038-d009-43a9-92e4-e8e9bbb86579.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODU3MDQsIm5iZiI6MTczOTI4NTQwNCwicGF0aCI6Ii8xMzk0OTAzMy80MDc5MTk3NjktNjc5NGUwMzgtZDAwOS00M2E5LTkyZTQtZThlOWJiYjg2NTc5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDE0NTAwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk2NzRmZDA2NmMxZTBjZmQ2ZmIwNzNkODkzZDRiZDlmNDBkODNmNmY2OGEyNjVmMTQ1NDFiNGJjZDI5MWViMDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.IDrCGTXK17nbAOFyQszroMqOsp7-ehJljvk1XWpcNMw)
physics1
in temp_suite.xml toradiation
, run the tests and look at the suite_part_list in the host Cap:The order is incorrect
The text was updated successfully, but these errors were encountered: