Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: options.stripFragment is renamed to options.stripHash #43

Closed
ghost opened this issue Dec 16, 2018 · 1 comment
Closed

Error: options.stripFragment is renamed to options.stripHash #43

ghost opened this issue Dec 16, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Dec 16, 2018

Are you submitting a bug report or a feature request?

Bug report

What is the current behavior?

Error while capture some site with Squidwarc:

A Fatal Error Occurred
  Error: options.stripFragment is renamed to options.stripHash
  
  - index.js:35 module.exports
    [Squidwarc]/[normalize-url]/index.js:35:9
  
  - _createHybrid.js:87 wrapper
    [Squidwarc]/[lodash]/_createHybrid.js:87:15
  
  - puppeteer.js:155 PuppeteerCrawler.navigate
    /home/sian1468/Squidwarc/lib/crawler/puppeteer.js:155:11
  

Please Inform The Maintainer Of This Project About It. Information In package.json

Example config and logs

What is the expected behavior?

Squidwarc working correctly.

What's your environment?

Fedora 29
node.js v11.4.0
Squidwarc 9bbc461

@machawk1
Copy link
Collaborator

machawk1 commented Dec 17, 2018

I encountered this in #39 as well. Exception src is

https://github.com/sindresorhus/normalize-url/blob/master/index.js#L34-L36

Swapping https://github.com/N0taN3rd/Squidwarc/blob/master/lib/utils/urlUtils.js#L26 to use stripHash instead of stripFragment might suffice, assuming the new attribute has the same semantics.

N0taN3rd added a commit that referenced this issue Dec 17, 2018
@ghost ghost closed this as completed Dec 18, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant