Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove later as a dependency #172

Open
nickbclifford opened this issue Aug 29, 2020 · 2 comments
Open

Remove later as a dependency #172

nickbclifford opened this issue Aug 29, 2020 · 2 comments

Comments

@nickbclifford
Copy link
Member

image

Not only is later deprecated, but since we continuously run the tasks server regardless, we really have no need for anything other than plain setInterval. We might also want to consider running a proper job scheduler that runs whole scripts as-needed instead (perhaps Bree).

@michaelgira23
Copy link
Member

My rationale was that setInterval might not be exactly what we want. Similar to how setTimeout is not precise, my understanding is that libraries like later make sure that our tasks run on-time and that a slight error doesn't compound into something bigger.

Either way, I can work on this

@nickbclifford
Copy link
Member Author

Understandable (TIL it's not that precise!), although on the timeframes that we're working with, I'm not sure it really matters, plus it's not really that important that our tasks run exactly at 12:00:00, 12:05:00, 12:10:00, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants