Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion]: Anti Drowning #66

Open
1 of 3 tasks
Mezimaru opened this issue Jul 20, 2023 · 5 comments
Open
1 of 3 tasks

[Suggestion]: Anti Drowning #66

Mezimaru opened this issue Jul 20, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@Mezimaru
Copy link

General Info

  • I would like to propose new content
  • I would like to propose changes
  • I would like to propose another thing

Suggestion Description

I'd still love some way to prevent Chocobo submerged in water from drowning if dismounted when they're under the stay command.
I personally am currently using

	if (this.isUnderWater()) {
		setNoAi(false);
		this.goalSelector.addGoal(0, this.follow);
		this.setMovementType(MovementType.FOLLOW_OWNER);
	}

But that's probably quite rudimentary, I'm sure you have another method you'd rather utilize

Love all the work you're doing <3

@Mezimaru Mezimaru added the enhancement New feature or request label Jul 20, 2023
@Mrbysco
Copy link
Owner

Mrbysco commented Jul 20, 2023

I rather not attach an AI goal every tick that the chocobo is underwater and never remove the goal

@Mezimaru
Copy link
Author

Hahaha yeah, which is why I said it was a quite rudimentary way of doing it ;P

Also, testing, I notice flying chocobo cannot submerge/swim the same way the blue+ chocobo can. Not sure if its a problem or anything, just something I noticed.

@Mrbysco
Copy link
Owner

Mrbysco commented Jul 20, 2023

I'm currently checking if the chocobo can stand on water because the chocobo's that can stand on water should also be able to swim more easily than the chocobo's that cant

@Mezimaru
Copy link
Author

Mezimaru commented Jul 20, 2023 via email

@Mezimaru
Copy link
Author

Also looks like yellow/green Chocobo are still stuck continuously jumping on the water surface if your holding jump and continue to hold jump for a second or two when jumping into the water.

Just tinkering around, commenting out the jumping below seemed to fix it for me, also was unable to determine any detriment from commenting it out in playtesting

else if (onGround()) {
jumpFromGround();
livingentity.setJumping(false);
//this.setJumping(true);
}

(Sorry, you're probably sick of me by now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants