Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.sh can be subsumed by CMake #23

Open
eyalroz opened this issue Aug 12, 2020 · 1 comment
Open

build.sh can be subsumed by CMake #23

eyalroz opened this issue Aug 12, 2020 · 1 comment

Comments

@eyalroz
Copy link

eyalroz commented Aug 12, 2020

Essentially all of the functionality in build.sh can be achieved in a relatively straightforward manner using just CMake's infrastructure. ccmake can be used to browse the various options, their descriptions and possible values, and the CMake configuration (as opposed to the generation) step can include the validity checks.

This would:

  • Reduce the amount of code and text
  • Simplify the CMakeLists.txt file somewhat
  • make it easier to adopt some modern CMake idioms
  • make it easiert to use CMake for installing the engine rather than just building
  • Enable CMake config-file-based dependency management where the engine is a dependency
@bernhardmgruber
Copy link

I just encountered a similar situation. The current workflow using build.sh does not play well with CMake supporting IDEs like Visual Studio or CLion, because these basically just invoke cmake and then infer the project settings from the CMakeCache or similar. With the current setup, no targets are enabled and there are also no options to configure through the IDE or cmake-gui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants