Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data presentation #6

Open
dmpayton opened this issue Nov 12, 2015 · 8 comments
Open

Data presentation #6

dmpayton opened this issue Nov 12, 2015 · 8 comments

Comments

@dmpayton
Copy link

Tables, graphs, and charts, oh my!

Once data has been fetched from Montage, the JS wrapper should be able to automatically present that data in some way on the page. This would be really useful for end-users of Montage as well as for Montage itself (on the data explorer).

The API needs to be thought out, but something along these lines:

car client = Client(...);
var data = Query( ... );
var table = MontageDataTable.render({client: client, query: query, **options});
table.render('.some-selector');

...or something.

It's an explicit decision to pass in the client and query separately. Once Montage supports websockets and changefeeds, the presenter could keep a connection open and update the chart/table/whatever in real time.

Since this is really only useful on the front-end -- not so much when querying in nodejs -- maybe this should be a separate project (montage-presenter?).

@dmpayton
Copy link
Author

Something else that needs to be solved is what will be used to render charts. Do we include a third-party charting library or roll our own?

@dphaener
Copy link

My two cents: Let's definitely not attempt to roll our own charting library. It's been done well several times, and I don't see the need to re-invent the wheel here. The only use case I could see for this is if we need functionality that doesn't exist in a current library. And even then, it would probably be a better idea to just fork a library and add it, instead recreating the whole thing.

@zackify
Copy link
Contributor

zackify commented Nov 13, 2015

@dphaener I have been meaning to make https://github.com/Legitcode/legit-chart a better wrapper for chartjs than https://github.com/Legitcode/react-chartjs so if you wanted to I could help :)

@dphaener
Copy link

@zackify What's wrong with Jed's wrapper? Seems pretty good to me, but then again I haven't tried to get in too deep with it.

@irms
Copy link

irms commented Nov 13, 2015

lol. I was just wondering if we should remove Zach from Github last night.

On Fri, Nov 13, 2015 at 10:56 AM, Zach Silveira [email protected]
wrote:

@dphaener https://github.com/dphaener I have been meaning to make
https://github.com/Legitcode/legit-chart a better wrapper for chartjs
than https://github.com/Legitcode/react-chartjs so if you wanted to I
could help :)


Reply to this email directly or view it on GitHub
#6 (comment)
.

@zackify
Copy link
Contributor

zackify commented Nov 13, 2015

I actually removed myself haha, just subscribed to a few of them still

On Fri, Nov 13, 2015 at 1:57 PM Irma L. Olguin Jr. [email protected]
wrote:

lol. I was just wondering if we should remove Zach from Github last night.

On Fri, Nov 13, 2015 at 10:56 AM, Zach Silveira [email protected]
wrote:

@dphaener https://github.com/dphaener I have been meaning to make
https://github.com/Legitcode/legit-chart a better wrapper for chartjs
than https://github.com/Legitcode/react-chartjs so if you wanted to I
could help :)


Reply to this email directly or view it on GitHub
<
#6 (comment)

.


Reply to this email directly or view it on GitHub
#6 (comment)
.

@dmpayton
Copy link
Author

I am -- at least initially, please prove me wrong -- against a chart solution (or wrapper) dependent on reactjs. The reason being that not all of our customers will be using react, and I don't want to force them to include react (or include it in our dist) just for some charting.

@dphaener
Copy link

No I completely agree. Don't let @zach butting in sway you. We definitely should not force anyone to use any library. Not even jquery imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants