Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for protocols with multiple time units specifications #151

Closed
MichaelClerx opened this issue Apr 8, 2020 · 3 comments
Closed

Comments

@MichaelClerx
Copy link
Contributor

Add some tests for edge cases:

  • Multiple independent var units declarations, with same units --> error?
  • Multiple independent var units declarations, with different units --> error
  • Time units set via independent var units and input/output, but OK --> not sure
  • Time units set via independent var units and input/output, but conflicting --> error
  • All of the above, but with part of the declarations in nested protocols
@jonc125
Copy link
Contributor

jonc125 commented Apr 8, 2020

  • Multiple independent var units declarations, with same units --> error?

Probably not, because that would most commonly arise in nested protocols.

  • Time units set via independent var units and input/output, but OK --> not sure

Think this is fine too. Redundant info, but that shouldn't prevent the protocol running.

  • All of the above, but with part of the declarations in nested protocols

The outcome should be the same. So can check just after interfaces are merged.

@MichaelClerx
Copy link
Contributor Author

See also #136

@MichaelClerx
Copy link
Contributor Author

Covered in #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants