Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency checks for model interface #105

Closed
4 tasks done
jonc125 opened this issue Feb 21, 2020 · 2 comments · Fixed by #158
Closed
4 tasks done

Consistency checks for model interface #105

jonc125 opened this issue Feb 21, 2020 · 2 comments · Fixed by #158

Comments

@jonc125
Copy link
Contributor

jonc125 commented Feb 21, 2020 •
edited by MichaelClerx
Loading

Have some sanity checks before/after modification that report errors helpfully for the user.

  • Double Inconsistent inputs
  • Double Inconsistent outputs
  • Input/output overlap: must have same units
  • Check that a variable isn't defined more than once in the interface. Have a check before making changes that we don't have 2 define and/or clamp clauses targeting the same variable, and produce a friendly error.
@MichaelClerx
Copy link
Contributor

I guess #130 is another one

@MichaelClerx
Copy link
Contributor

I think we've more or less got this in #158 ?

@MichaelClerx MichaelClerx mentioned this issue Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parsing optional statements in model interface. ModellingWebLab/weblab-fc
2 participants
@MichaelClerx @jonc125